Pushed: http://hg.openjdk.java.net/jdk9/client/jdk/rev/3eda6cd3f504
Thanks for your reviews !
Laurent
2016-02-10 22:27 GMT+01:00 Jim Graham :
> Looks good...
>
> ...jim
>
> On 2/10/16 12:52 PM, Laurent Bourgès wrote:
>
>> Jim & Phil,
>>
>> Here is the updated webrev:
>>
Hello,
Could you please review the fix for JDK-8147807 and approve push to 8u-dev?
JBS: https://bugs.openjdk.java.net/browse/JDK-8147807
Webrev: http://cr.openjdk.java.net/~aivanov/8147807/jdk8/webrev.00/
The issue is not relevant to jdk 9.
The fix just removes kcms service leaving lcms as the
Hi,
Please review the following fix in JDK9:
Bug : https://bugs.openjdk.java.net/browse/JDK-7116979
Webrev : http://cr.openjdk.java.net/~jdv/7116979/webrev.00/
Issue : When Image containing black pixels are converted from any format to
Byte Indexed format some of the pixels are n
It all looks great. The comments are fine for internal documentation,
but here is a suggestion for the initial comment on a couple of the
Provider classes. I don't need to review the changes to comments.
(NOTE: Watch out for trailing white space on these if you cut and past
them back as the
Hi Jayathirth,
Did you do any performance analysis of this change? You are adding 6
tests and multiple branches to per-pixel code.
The effectiveness of this technique depends on the colormap that we have
set up. For the BufferedImage.TYPE_INDEXED constructor we produce a
fairly nice colorm
Code pushed. To be certain I fixed the bug in my script, ran it against the
same code, and compared the results. As the results were the same, it looked
good.
Brian
On Feb 10, 2016, at 7:12 PM, Brian Burkhalter
wrote:
> I don’t think that there was any problem with the script, just operator
Hello,
Please review a candidate fix for
JDK-8148914: BitDepth.java test fails
In brief, OpenJDK supports two fewer buffered image formats for jpg than
the closed JDK does. I've modified the BitDepth test to allow for this
difference. Patch below; webrev at
http://cr.openjdk.java.ne
