Re: [OpenJDK 2D-Dev] [8u-dev] Request for review and approval for bug 8147807: crash in libkcms.so on linux-sparc

2016-02-12 Thread Alexey Ivanov
I forgot to add jdk8u-dev list... On 11.02.2016 17:19, Alexey Ivanov wrote: Hello, Could you please review the fix for JDK-8147807 and approve push to 8u-dev? JBS: https://bugs.openjdk.java.net/browse/JDK-8147807 Webrev: http://cr.openjdk.java.net/~aivanov/8147807/jdk8/webrev.00/ The issue

Re: [OpenJDK 2D-Dev] RFR 8148886: SEGV in sun.java2d.marlin.Renderer._endRendering

2016-02-12 Thread Laurent Bourgès
Jim & Phil, 2016-02-11 23:20 GMT+01:00 Jim Graham : > It all looks great. The comments are fine for internal documentation, but > here is a suggestion for the initial comment on a couple of the Provider > classes. I don't need to review the changes to comments. > Thanks Jim for your carefull

Re: [OpenJDK 2D-Dev] [8u-dev] Request for review and approval for bug 8147807: crash in libkcms.so on linux-sparc

2016-02-12 Thread Seán Coffey
Approved for jdk8u-dev once you have a peer code review. Regards, Sean. On 12/02/2016 08:19, Alexey Ivanov wrote: I forgot to add jdk8u-dev list... On 11.02.2016 17:19, Alexey Ivanov wrote: Hello, Could you please review the fix for JDK-8147807 and approve push to 8u-dev? JBS: https://bug

[OpenJDK 2D-Dev] RFR: add regression test for JDK-8144991

2016-02-12 Thread Alexander Stepanov
Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8149558/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8149558 Just a single regression test added (still failing), plus minor correction for other test. Thanks, Alexander

Re: [OpenJDK 2D-Dev] [8u-dev] Request for review and approval for bug 8147807: crash in libkcms.so on linux-sparc

2016-02-12 Thread Magnus Ihse Bursie
On 2016-02-12 10:15, Seán Coffey wrote: Approved for jdk8u-dev once you have a peer code review. Makefile change look good. /Magnus Regards, Sean. On 12/02/2016 08:19, Alexey Ivanov wrote: I forgot to add jdk8u-dev list... On 11.02.2016 17:19, Alexey Ivanov wrote: Hello, Could you pleas

Re: [OpenJDK 2D-Dev] [9] Review request for 8142966 Wrong cursor position in text components on HiDPI display

2016-02-12 Thread Alexander Scherbatiy
On 09/02/16 18:56, Sergey Bylokhov wrote: Also probably it will be possible to test this via the public api only(using the mix of the graphics transform + font transform). On 09.02.16 17:47, Sergey Bylokhov wrote: Some additional information. The Swing calculates the size of the components a

Re: [OpenJDK 2D-Dev] [9] Review request for 8076545 Text size is twice bigger under Windows L&F on Win 8.1 with HiDPI display

2016-02-12 Thread Alexandr Scherbatiy
On 2/8/2016 3:04 PM, Jim Graham wrote: I don't understand the issue with the fonts that you are saying have different sizes for different DPIs. Those are pixel sizes, aren't they? They still need to be turned into user-space units for our applications to know what to do with them. Or, are yo