Looks good.
/Erik
On 2016-02-12 10:15, Seán Coffey wrote:
Approved for jdk8u-dev once you have a peer code review.
Regards,
Sean.
On 12/02/2016 08:19, Alexey Ivanov wrote:
I forgot to add jdk8u-dev list...
On 11.02.2016 17:19, Alexey Ivanov wrote:
Hello,
Could you please review the fix for
Hi Phil,
>> Line 836 should be
>> x = (bounds.x + bounds.width) - dlgBound.width
can be wrong if (bounds.x + bounds.width) - dlgBound.width comes out to
be negative (or less than window top-left x,y coordiantes)
For example, if window bounds for secondary monitor is (x=1600, y=0,
width=489, he
Hi Jim,
I performed performance analysis with white image so that all conditions are
checked in the new branch added. There is no major difference in time taken
before and after change. For each input I have tested time taken for
drawImage() API to convert from every format to Byte indexed t
Any comments on this?
Thanks,
-Joe
On 2/11/2016 6:00 PM, joe darcy wrote:
Hello,
Please review a candidate fix for
JDK-8148914: BitDepth.java test fails
In brief, OpenJDK supports two fewer buffered image formats for jpg
than the closed JDK does. I've modified the BitDepth test to allo
How do create the palette?
Brian
On Feb 15, 2016, at 3:39 AM, Jayathirth D V wrote:
> Hi Jim,
>
> I performed performance analysis with white image so that all conditions are
> checked in the new branch added. There is no major difference in time taken
> before and after change. For each in
Thanks Alexandr,
The AWT changes all look good.
I'll leave it to others as to whether the test case represents the best
way to test this. I have no idea how those two font values in those two
L&F's in a Swing button should compare - maybe a difference of 8 is
ordinary under some circumstance
Hi Jayathirth,
The issue with testing performance with white images is that the tests
allow the code to eliminate 3 indexed fetches which take time. Primary
colors end up being the one obscure case where the new code might be
faster. But, non-primary colors would be slower by a fair amount,
Hi Joe,
Might it not be better to modify testWriteRGB() to do something like this (code
neither compiled nor tested):
ImageTypeSpecifier spec = new ImageTypeSpecifier(bi);
Iterator writers = ImageIO.getImageWriters(spec, format).next();
File file = new File("BitDepth_" + biTypeNames[type] + "."
Assuming it works, this approach seems better.
-phil.
On 02/15/2016 11:39 AM, Brian Burkhalter wrote:
Hi Joe,
Might it not be better to modify testWriteRGB() to do something like
this (code neither compiled nor tested):
ImageTypeSpecifier spec = new ImageTypeSpecifier(bi);
Iterator writers
Hello,
The the FloatConsts and DoubleConsts classes, while moved to an internal
package recently (JDK-8145990), contain constants now available via the
public API. All such uses of the redundant values should be removed as
well as the redundant constants themselves.
A quick note on the 2d ch
On 2/15/2016 1:58 PM, Phil Race wrote:
Assuming it works, this approach seems better.
A slightly modified version of Brian's change does the trick.
Patch below and updated webrev at
http://cr.openjdk.java.net/~darcy/8148914.1/
Thanks,
-Joe
diff -r 10e298cb4ef1 test/javax/imageio/plugin
11 matches
Mail list logo
