Re: [OpenJDK 2D-Dev] [9]: RFR JDK-8058316, , lookupDefaultPrintService returns null on Solaris 11

2016-03-04 Thread prasanta sadhukhan
Hi Phil, Please find the modified webrev http://cr.openjdk.java.net/~psadhukhan/8058316/webrev.01/ Regards Prasanta On 3/4/2016 3:21 AM, Phil Race wrote: I think there is a small memory leak with this code : https://www.cups.org/documentation.php/doc-2.0/api-cups.html#cupsGetDests "Use the cup

[OpenJDK 2D-Dev] [9] RFR JDK-8034239, , PrintServiceLookup.lookupPrintServices() returns different amount of services in comparison with lpstat -v

2016-03-04 Thread prasanta sadhukhan
Hi Phil, Please review a print service fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-8034239 webrev: http://cr.openjdk.java.net/~psadhukhan/8034239/webrev.00/ The issue was lpstat -v was reporting 2 printer service but PrintServiceLookup.lookupPrintServices() list only 1. #lpstat

Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel

2016-03-04 Thread Jayathirth D V
Hi Jim, I have updated the code to remove indentation problem and added VolatileImage also for testing. Please find the updated webrev for review : http://cr.openjdk.java.net/~jdv/8139183/webrev.03/ Thanks, Jay -Original Message- From: Jim Graham Sent: Friday, March 04, 2016 5:21 AM

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-8058316, , lookupDefaultPrintService returns null on Solaris 11

2016-03-04 Thread Phil Race
Approved. -phil. On 03/04/2016 02:47 AM, prasanta sadhukhan wrote: Hi Phil, Please find the modified webrev http://cr.openjdk.java.net/~psadhukhan/8058316/webrev.01/ Regards Prasanta On 3/4/2016 3:21 AM, Phil Race wrote: I think there is a small memory leak with this code : https://www.cups.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8034239, , PrintServiceLookup.lookupPrintServices() returns different amount of services in comparison with lpstat -v

2016-03-04 Thread Phil Race
if the class is supposed to use the return value in this way what about these lines :- 1209 1210 public boolean isIPPSupportedImages(String mimeType) { 1211 if (supportedDocFlavors == null) { 1212 getSupportedDocFlavors(); 1213 } It looks to me as if what you sho