Re: [OpenJDK 2D-Dev] [9]: RFR JDK-6357905, , java.awt.JobAttributes.getFromPage() and getToPage() always returns "1".

2016-03-31 Thread Philip Race
Actually never mind about the > or >= difference that code is fine since it is the condition under which the exception is thrown not the condition that the setting is accepted ! But you do still need to check the existing values to see which order to do the update. -phil On 3/31/16, 8:44 AM, Ph

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-6357905, , java.awt.JobAttributes.getFromPage() and getToPage() always returns "1".

2016-03-31 Thread Philip Race
On 3/30/16, 10:22 PM, prasanta sadhukhan wrote: Hi Phil, I found out we do not need to change minPage. That makes more sense now. Changing toPage before frompage should be enough. Please find the modified webrev: http://cr.openjdk.java.net/~psadhukhan/6357905/webrev.01/ Don't you need to

[OpenJDK 2D-Dev] RFR 8149028: [TEST] add test for TIFFDirectory

2016-03-31 Thread Alexander Stepanov
Please see http://cr.openjdk.java.net/~avstepan/8149028/webrev.02/ (one more test covering TIFFImageReadParam was added). Thanks, Alexander On 3/29/2016 8:21 PM, Alexander Stepanov wrote: Please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8149028/webrev.01/ (one more test was a

Re: [OpenJDK 2D-Dev] RFR 8149028: [TEST] add test for TIFFDirectory

2016-03-31 Thread Semyon Sadetsky
Looks good. --Semyon On 3/31/2016 6:52 PM, Alexander Stepanov wrote: Please see http://cr.openjdk.java.net/~avstepan/8149028/webrev.02/ (one more test covering TIFFImageReadParam was added). Thanks, Alexander On 3/29/2016 8:21 PM, Alexander Stepanov wrote: Please see the updated webrev: http

Re: [OpenJDK 2D-Dev] [9] Review request for 8073320 Windows HiDPI Graphics support

2016-03-31 Thread Jim Graham
Hi Alexandr, Is there a bug filed to upgrade JLightweightFrame to allow non-integer (and X/Y) scales? We'd need this capability to implement "Swing embedded in FX" correctly on Win8.1+... ...jim On 9/22/2015 2:33 AM, Alexander Scherbatiy wrote: Hello, Could you re