Re: [OpenJDK 2D-Dev] [9]: RFR JDK-6357905, , java.awt.JobAttributes.getFromPage() and getToPage() always returns "1".

Please find the modified webrev with check for existing values to select which order to do the update. http://cr.openjdk.java.net/~psadhukhan/6357905/webrev.02/ I have checked with 1) initially user sets from=3, to=4 and then user change from=1,to=2 2) initially user sets from=3, to=4 and then u

Re: [OpenJDK 2D-Dev] RFR 8149028: [TEST] add test for TIFFDirectory

Thanks! On 3/31/2016 8:10 PM, Semyon Sadetsky wrote: Looks good. --Semyon On 3/31/2016 6:52 PM, Alexander Stepanov wrote: Please see http://cr.openjdk.java.net/~avstepan/8149028/webrev.02/ (one more test covering TIFFImageReadParam was added). Thanks, Alexander On 3/29/2016 8:21 PM, Alexand

Re: [OpenJDK 2D-Dev] RFR 8149028: [TEST] add test for TIFFDirectory

+1 -yan On 03/31/2016 06:52 PM, Alexander Stepanov wrote: Please see http://cr.openjdk.java.net/~avstepan/8149028/webrev.02/ (one more test covering TIFFImageReadParam was added). Thanks, Alexander On 3/29/2016 8:21 PM, Alexander Stepanov wrote: Please see the updated webrev: http://cr.openj

[OpenJDK 2D-Dev] [9] RFR: JDK-8074826, , Resolve disabled warnings for liblcms

Hi All, Please review a fix to remove the disabled warnings from lcms library Bug: https://bugs.openjdk.java.net/browse/JDK-8074826 webrev: http://cr.openjdk.java.net/~psadhukhan/8074826/webrev.00/ One issue was snprintf/sprintf was using arguments it8 ->DoubleFormatter instead of string forma

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8074826, , Resolve disabled warnings for liblcms

Thanks for fixing this! The build change looks fine. Someone else should look at the code changes. /Erik On 2016-04-01 12:57, prasanta sadhukhan wrote: Hi All, Please review a fix to remove the disabled warnings from lcms library Bug: https://bugs.openjdk.java.net/browse/JDK-8074826 webrev: h

[OpenJDK 2D-Dev] RFR: 8153272: Fix @run tag in CreateFontArrayTest.java

A simple one .. any one reviewer will do. Fix is inline below. Bug :https://bugs.openjdk.java.net/browse/JDK-8153272 -phil. --- a/test/java/awt/FontClass/CreateFont/CreateFontArrayTest.java +++ b/test/java/awt/FontClass/CreateFont/CreateFontArrayTest.java @@ -23,9 +23,9 @@ /* * @test - * @bu

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8074826, , Resolve disabled warnings for liblcms

Sorry, no we don't want this patch. We are not fixing warnings in upstream libraries. -phil. On 04/01/2016 03:57 AM, prasanta sadhukhan wrote: Hi All, Please review a fix to remove the disabled warnings from lcms library Bug: https://bugs.openjdk.java.net/browse/JDK-8074826 webrev: http://cr.o

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-6357905, , java.awt.JobAttributes.getFromPage() and getToPage() always returns "1".

Looks good ! -phil. On 04/01/2016 12:02 AM, prasanta sadhukhan wrote: Please find the modified webrev with check for existing values to select which order to do the update. http://cr.openjdk.java.net/~psadhukhan/6357905/webrev.02/ I have checked with 1) initially user sets from=3, to=4 and th

Re: [OpenJDK 2D-Dev] RFR 8152183: [TEST] add test for TIFFField

Please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8152183/webrev.01/ One more test (for multi-page tiffs) was added; for now to be ignored because of JDK-8148454 Thanks, Alexander On 3/28/2016 1:07 PM, Alexander Stepanov wrote: Sorry, just a reminder. Thanks, Alexander On

[OpenJDK 2D-Dev] RFR: 8147544: Remove sun.misc.ManagedLocalsThread from java.desktop

Bug: https://bugs.openjdk.java.net/browse/JDK-8147544 Fix: http://cr.openjdk.java.net/~prr/8147544/ ManagedLocalThreads is now superseded by a standard constructor on java.lang.Thread :- http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f90cd2c011bc The various places in JDK that use the internal API