Re: [OpenJDK 2D-Dev] RFR 8152183: [TEST] add test for TIFFField

2016-04-06 Thread Alexander Stepanov
Hello Phil, > I did not think you could assume $CWD is writeable in jtreg tests. according to the jtreg docs, "when jtreg is executed, it cd's into a scratch". Could the scratch dir be non-writable? At a 1st glance it seems to be unlikely, but maybe I'm wrong. Thanks, Alexander On 4/6/2016

[OpenJDK 2D-Dev] [9] RFR: JDK-6529030, , Java Printing: Print range > Selection gets enabled

2016-04-06 Thread prasanta sadhukhan
Hi All, Please review a fix for jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-6529030 webrev: http://cr.openjdk.java.net/~psadhukhan/6529030/webrev.00/ The issue was when using java.awt.print.PrinterJob instance more then once, Selection radio button in Print dialog gets enabled from 2nd

Re: [OpenJDK 2D-Dev] RFR 8152183: [TEST] add test for TIFFField

2016-04-06 Thread Alexander Stepanov
P.S.: and even if scratch is accidentally non-writable (which is definitely an exceptional situation), then the 'writeImage()' method will throw a proper Exception, so it seems there is no need in additional checks here. Thanks, Alexander On 4/6/2016 12:21 PM, Alexander Stepanov wrote: Hello

[OpenJDK 2D-Dev] [9] RFR: PrinterJob.getUserName() throws a security exception when user.name permission is not given

2016-04-06 Thread prasanta sadhukhan
Hi All, Please review a document fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-6197099 webrev: http://cr.openjdk.java.net/~psadhukhan/6197099/webrev.00/ PrinterJob.getUserName() is supposed to return the current user name of the system. This method does not document any exception.

[OpenJDK 2D-Dev] Review Request for JDK-7107905: equals() method in IndexColorModel doesnt exist and it relies on ColorModel.equals() which is not strict

2016-04-06 Thread Jayathirth D V
Hi, Please review the following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-7107905 Webrev : http://cr.openjdk.java.net/~jdv/7107905/webrev.00/ Issue : When we compare two IndexColorModel objects with different ColorMap(or any other property specific to IndexColo

Re: [OpenJDK 2D-Dev] RFR: 8134986: Incorrect use of ConcurrentHashMap.contains in SunFontManager.java

2016-04-06 Thread Sergey Bylokhov
Looks fine. On 05.04.16 1:33, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8134986 When converted from a HashSet to a HashMap contains() should have changed to containsKey(). It does not lead to duplicate fonts because it is caught later on but it might lead to wasted work One lin

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: equals() method in IndexColorModel doesnt exist and it relies on ColorModel.equals() which is not strict

2016-04-06 Thread Jim Graham
Are there any bugs in the database about the fact that many of these ColorModel subclasses implement equals without hashcode? They really should both be implemented, but since ColorModel implements the method based on its tests, they are technically covered by the equals/hashCode contract - it