Hi All,
Please review a fix for jdk9.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154057
webrev: http://cr.openjdk.java.net/~psadhukhan/8154057/webrev.00/
As per spec, Toolkit.getPrintJob() should throw NPE if null frame object
is passed to it.
But on macos, it seems getPrintJob() does not c
Hi Jim,
I have updated the webrev to include changes to check testBit() instead of
using isValid().
Please find the updated webrev for review:
http://cr.openjdk.java.net/~jdv/7107905/webrev.03/
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Tuesday, April 12, 2016 12:21 AM
To:
Looks fine.
On 11.04.16 16:53, Alexey Ivanov wrote:
Hello Dmitry,
Thank you very much for your patch.
The fix looks good to me.
I will sponsor integrating the fix into the code base as soon as code
review is complete.
Thanks,
Alexey
On 07.04.2016 15:26, Dmitry Batrak wrote:
Hello,
I'd lik
please resubmit this review request with the bug id in the subject line.
-phil.
On 04/12/2016 04:16 AM, prasanta sadhukhan wrote:
Hi All,
Please review a fix for jdk9.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154057
webrev: http://cr.openjdk.java.net/~psadhukhan/8154057/webrev.00/
As pe
Sorry not this one
I meant a different review
:http://mail.openjdk.java.net/pipermail/2d-dev/2016-April/006670.html
-phil
On 04/12/2016 10:02 AM, Phil Race wrote:
please resubmit this review request with the bug id in the subject line.
-phil.
On 04/12/2016 04:16 AM, prasanta sadhukhan wro
hmm .. if it does not throw NPE when the dialog type is common that
could mean
that the code is not referencing the frame as a modal parent /owner in
that case which could
be another bug.
Did you check into how this is used relative to other platforms ?
-phil.
On 04/12/2016 04:16 AM, prasanta
Alexey didn't say this but he already proposed exactly this fix himself
in a private email exchange,
+1, although I am not sure we can legally pull down the patch from that
(any) website.
Please resubmit it as a diff in the email.
Or Alexey could just push it as his own :-)
-phil.
On 04/07/2
Repeating the patch inline:
=== patch start ===
--- old/src/java.desktop/windows/native/libfontmanager/lcdglyph.c
2016-04-07 13:10:01.507608685 +0300
+++ new/src/java.desktop/windows/native/libfontmanager/lcdglyph.c
2016-04-07 13:10:01.391608686 +0300
@@ -157,6 +157,9 @@
if (hBitmap != 0) { \
Hi Jay,
Looks great! Good to go...
...jim
On 4/12/2016 4:36 AM, Jayathirth D V wrote:
Hi Jim,
I have updated the webrev to include changes to check testBit() instead of
using isValid().
Please find the updated webrev for review:
http://cr.openjdk.java.net/~jdv/710790
I am catching up on email here, and "+1" but a couple of comments
- ColorModel.hashCode() doesn't say a lot about how it is calculated
so it seems safe to change it. Sometimes it makes performance sense
to cache the calculated value but in this case there is probably no
big win from doing so sinc
On 4/12/2016 12:59 PM, Phil Race wrote:
I am catching up on email here, and "+1" but a couple of comments
- I suppose that we can't learn anything useful from
"cm.validbits.equals(this.validbits)"
since only the bits up to "map_size" should be tested ?
Perhaps if the constructors truncated i
Seems like this would work/help.
-phil.
On 04/12/2016 01:19 PM, Jim Graham wrote:
On 4/12/2016 12:59 PM, Phil Race wrote:
I am catching up on email here, and "+1" but a couple of comments
- I suppose that we can't learn anything useful from
"cm.validbits.equals(this.validbits)"
since only t
Hello,
Please review the fix for jdk9.
This test uncover a few issues:
Test bug:
- Fail on HiDPI system, because the test tries to check the rendering
to the BufferedImage and VolaileImage using some threshold. Fixed by the
"-Dsun.java2d.uiScale=1" option.
jdk bug:
- timeout error (in the b
Hi,
My reading here :
https://msdn.microsoft.com/en-us/library/windows/desktop/ms646843%28v=vs.85%29.aspx
of the meaning of PD_NOSELECTION is that it disables the SELECTION radio
button such
that the user *cannot* select it.
Is that true ? If so this seems like it cannot be the right fix for
Resending with bugid in the subject line.
On 4/6/2016 5:06 PM, prasanta sadhukhan wrote:
Hi All,
Please review a document fix for jdk9
Bug: https://bugs.openjdk.java.net/browse/JDK-6197099
webrev: http://cr.openjdk.java.net/~psadhukhan/6197099/webrev.00/
PrinterJob.getUserName() is supposed to
15 matches
Mail list logo
