+1
-phil.
On 6/1/16, 12:03 AM, prasanta sadhukhan wrote:
HI Phil, Jim,
I have modified webrev to address Jim's doc change. Please review
http://cr.openjdk.java.net/~psadhukhan/6842011/webrev.02/
I will send the ccc link separately to you for approval.
On 5/31/2016 11:12 PM, Phil Race
Hi Phil, Sergey,
Thank you for reviewing!
I suggest pushing the current version of the fix:
http://cr.openjdk.java.net/~bae/8078382/9/webrev.00/
It's Andrew's fix, and I'll push it under his name, giving him the credit.
As for FontFamily.getClosestStyle(), I'll submit a new bug to
+1 from me ..
-phil
On 06/01/2016 03:28 AM, Ajit Ghaisas wrote:
Thanks Jim and Phil for valuable feedback and suggestions.
The detailed discussion helped me to understand why catching RuntimeException
is a better option for a call to imageComplete(STATICIMAGEDONE).
I have modified the code
you call super.paintComponent(g); twice in lines 956 and 964. Is it
expected behavior?
--Semyon
On 6/1/2016 7:58 PM, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8158408
Webrev: http://cr.openjdk.java.net/~prr/8158408/
At 125% scaling on JDK 9 Font2DTest looks horrid
Looks good to me.
--Semyon
On 6/1/2016 9:44 PM, Phil Race wrote:
On 06/01/2016 11:05 AM, Semyon Sadetsky wrote:
you call super.paintComponent(g); twice in lines 956 and 964. Is it
expected behavior?
Yes, if "CannotDrawException" is caught we want to repaint using super
else, we will
may
On 06/01/2016 11:05 AM, Semyon Sadetsky wrote:
you call super.paintComponent(g); twice in lines 956 and 964. Is it
expected behavior?
Yes, if "CannotDrawException" is caught we want to repaint using super
else, we will
may have a partially panel.
-phil.
--Semyon
On 6/1/2016 7:58 PM,
I'm a little disturbed that we are just doing a basic "look for these byte value" type of search rather than parsing the
file until we find an SOI. Are there cases where we are skipping arbitrary untagged data, or was this just lazy
programming in the first place. Everything in a JPEG file
Please post the updated webrev.
-phil.
On 6/1/16, 12:02 AM, Jayathirth D V wrote:
Hi Phil& Jim,
Collating all the changes needed:
1) I have removed both equals()& hashCode() in CCM but forgot to add the file
while creating webrev. I will include changes in CCM in updated webrev.
2) Caching
Bug: https://bugs.openjdk.java.net/browse/JDK-8158408
Webrev: http://cr.openjdk.java.net/~prr/8158408/
At 125% scaling on JDK 9 Font2DTest looks horrid since its
BufferedImage is scaled to the screen.
Fix is to not use a BufferedImage, just use the Swing back buffer.
-phil.
I am bit doubtful about this. Are you sure we are correct in reporting
two images to begin with ?
Thumbnails should not get counted ..
-phil.
On 06/01/2016 01:06 AM, Jayathirth D V wrote:
Updated bug title in JBS as it was misleading.
*From:* Jayathirth D V
*Sent:* Wednesday, June 01, 2016
Looks good. +1
...jim
On 6/1/16 12:03 AM, prasanta sadhukhan wrote:
HI Phil, Jim,
I have modified webrev to address Jim's doc change. Please review
http://cr.openjdk.java.net/~psadhukhan/6842011/webrev.02/
I will send the ccc link separately to you for approval.
On
+1.
If you wanted to add a comment on the new catch, you could say:
} catch (RuntimeException e) {
// We did not previously call this method here and some filters
// were not prepared for it to be called at this time so we
// allow them to have runtime issues for this one call only
Hi,
Please review the following fix in JDK9:
Bug : https://bugs.openjdk.java.net/browse/JDK-8152672
Webrev : http://cr.openjdk.java.net/~jdv/8152672/webrev.00/
Issue : When we are trying to get properties related to second image in JPEG
file we are getting IIOException
Updated bug title in JBS as it was misleading.
From: Jayathirth D V
Sent: Wednesday, June 01, 2016 12:48 PM
To: Philip Race; Jim Graham
Cc: 2d-dev@openjdk.java.net
Subject: Review Request for JDK-8152672 : Exception getting thumbnail size for
JPEG with embedded thumbnail
Hi,
Please
HI Phil, Jim,
I have modified webrev to address Jim's doc change. Please review
http://cr.openjdk.java.net/~psadhukhan/6842011/webrev.02/
I will send the ccc link separately to you for approval.
On 5/31/2016 11:12 PM, Phil Race wrote:
On 05/26/2016 03:49 AM, prasanta sadhukhan wrote:
Hi
Hi Phil,
Ok. So, it seems we do not need to make change to gc definition.
I just modified x,y to specify it is relative to gc.
http://cr.openjdk.java.net/~psadhukhan/6212751/webrev.01/
Do you think it's ok? or do you think our explanation in the javadocs is
good enough and we can close this
Hi Phil,
On 01.06.2016 0:07, Phil Race wrote:
getClosestStyle() is something of a last resort.
Historically I think it was called only when you
had only a font *with* a style like bold and someone asked for
plain/regular.
ie for the subtractive case rather than the additive case.
So it would
Hi Sergey,
On 31.05.2016 19:43, Sergey Bylokhov wrote:
On 31.05.16 19:30, Phil Race wrote:
The patch changes the order of font selection: bold will be used, if
possible, as the base for bold-italic instead of italic which is the
current default. It also fixes the issue where italic is returned
18 matches
Mail list logo
