Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

2016-07-29 Thread Vadim Pakhnushev
Phil, I guess you wanted to remove the lines in the Awt2dLibraries.gmk? Do you think it's worth it to rewrite these assignments as separate assignment and a condition? Especially long ones with a lot of parentheses? Like this one, instead of if ((j = ((mlib_s32) ((mlib_addr) psrc_row & 4) >>

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

2016-07-29 Thread Vadim Pakhnushev
On 29.07.2016 17:30, Philip Race wrote: On 7/29/16, 7:00 AM, Vadim Pakhnushev wrote: On 29.07.2016 16:28, Philip Race wrote: On 7/29/16, 3:23 AM, Vadim Pakhnushev wrote: Phil, I guess you wanted to remove the lines in the Awt2dLibraries.gmk? Ah, yes. Not just disable them Do you

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

2016-07-29 Thread Philip Race
On 7/29/16, 3:23 AM, Vadim Pakhnushev wrote: Phil, I guess you wanted to remove the lines in the Awt2dLibraries.gmk? Ah, yes. Not just disable them Do you think it's worth it to rewrite these assignments as separate assignment and a condition? Especially long ones with a lot of

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

2016-07-29 Thread Vadim Pakhnushev
On 29.07.2016 16:28, Philip Race wrote: On 7/29/16, 3:23 AM, Vadim Pakhnushev wrote: Phil, I guess you wanted to remove the lines in the Awt2dLibraries.gmk? Ah, yes. Not just disable them Do you think it's worth it to rewrite these assignments as separate assignment and a condition?

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

2016-07-29 Thread Philip Race
On 7/29/16, 7:00 AM, Vadim Pakhnushev wrote: On 29.07.2016 16:28, Philip Race wrote: On 7/29/16, 3:23 AM, Vadim Pakhnushev wrote: Phil, I guess you wanted to remove the lines in the Awt2dLibraries.gmk? Ah, yes. Not just disable them Do you think it's worth it to rewrite these

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

2016-07-29 Thread Vadim Pakhnushev
Looks good! Vadim On 30.07.2016 6:49, Philip Race wrote: See http://cr.openjdk.java.net/~prr/8074843.1/ Also passes JPRT -phil. On 7/29/16, 7:35 AM, Vadim Pakhnushev wrote: On 29.07.2016 17:30, Philip Race wrote: On 7/29/16, 7:00 AM, Vadim Pakhnushev wrote: On 29.07.2016 16:28, Philip