Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8158524: Test file added for VolatileImage -vs- BufferedImage output comparison

2016-08-16 Thread Prahalad Kumar Narayanan
Hello Everyone This is a follow-up to my webrev. Thanks to Sergey for his feedback. I 've incorporated the feedback and changes are now available for review Link: http:// http://cr.openjdk.java.net/~pnarayanan/8158524/webrev.02/ Summary on changes from previous revision: . '@ke

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8158524: Test file added for VolatileImage -vs- BufferedImage output comparison

2016-08-16 Thread Sergey Bylokhov
Looks fine. On 16.08.16 11:11, Prahalad Kumar Narayanan wrote: Hello Everyone This is a follow-up to my webrev. Thanks to Sergey for his feedback. I 've incorporated the feedback and changes are now available for review Link: http:// http://cr.openjdk.java.net/~pnarayanan/8158524/we

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

2016-08-16 Thread Prasanta Sadhukhan
Hi All, On 8/11/2016 2:08 PM, Prasanta Sadhukhan wrote: Hi Phil, On 8/11/2016 3:05 AM, Phil Race wrote: There does not seem to be a link to the new webrev in here. Is it this : http://cr.openjdk.java.net/~psadhukhan/6574279/webrev.01/ ? > to default Paper (Letter in US, A4 otherwise) imageab

[OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

2016-08-16 Thread Brian Burkhalter
Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8149562 Patch: [1] Add one sentence to the TIFFField.createFromMetadataNode method specification stating that the supplied Node parameter must adhere to the TIFFField element structure defined by the TIFF nativ

[OpenJDK 2D-Dev] [9] Review Request: 8164104 Cleanup of javaclient related mapfiles

2016-08-16 Thread Sergey Bylokhov
Hello. Please review cleanup of mapfiles, initially the problem was found here: http://mail.openjdk.java.net/pipermail/awt-dev/2016-August/011734.html - tabs were replaced by spaces - doubled empty lines removed jprt is ok. Bug: https://bugs.openjdk.java.net/browse/JDK-8164104 Patch can be f

[OpenJDK 2D-Dev] [9] Review Request: 8164104 Cleanup of javaclient related mapfiles

2016-08-16 Thread Sergey Bylokhov
Hello. Please review cleanup of mapfiles, initially the problem was found here: http://mail.openjdk.java.net/pipermail/awt-dev/2016-August/011734.html - tabs were replaced by spaces - doubled empty lines removed jprt is ok. Bug: https://bugs.openjdk.java.net/browse/JDK-8164104 Patch can be f

Re: [OpenJDK 2D-Dev] [9] Review Request: 8164104 Cleanup of javaclient related mapfiles

2016-08-16 Thread Phil Race
I think "JPRT is OK" is good but may be not enough here? I am not sure if the build will complain about missing entries for JNI methods since there is no direct linking against these. Can you do a quick sanity run through of Java2Demo on Linux .. and ideally Solaris x64 too. -phil. On 08/16/2016