Hi Phil,
I assumed setjmp/longjmp functions to be internal error handling mechanism
rather than C standard library functions which provide non-local jumps.
I verified setjmp/longjmp usage in ImageIO JPEG context and we need that
RELEASE_ARRAYS() call in writeImage() which I have removed.
Do
The changes looks fine, should we increment version=1 to other version
or it is not used? Unrelated question is how we validate all these paths
if some of them are absent?
On 23.09.16 8:08, Philip Race wrote:
PING .. any takers on this two week old RFR ?
-phil.
On 9/8/16, 1:12 PM, Philip Rac
Hi Phil,
Please find the modified webrev:
http://cr.openjdk.java.net/~psadhukhan/8165947/webrev.01/
Regards
Prasanta
On 9/22/2016 11:10 PM, Prasanta Sadhukhan wrote:
On 9/22/2016 11:09 PM, Philip Race wrote:
OK I see now.
The comment should be updated to remove mention of the dialog
and expl
The JDK changes are fine but I don't think the test is.
It assumes that the system default is no banner page.
You need to update the test to check what the system default is
(banner or no banner) and have the tester "expect" whatever that happens
to be.
-phil
On 9/23/16, 8:30 AM, Prasanta Sad
You can't re-use the 9 bug ID in 9. So you will need to create a new bug
to fix
that in 9.
But for 8u it can be part of this fix .. it would be weird to knowingly
check in
a problem just so you could fix it separately.
-phil.
On 9/23/16, 12:13 AM, Jayathirth D V wrote:
Hi Phil,
I assumed
Updated the testcase:
http://cr.openjdk.java.net/~psadhukhan/8165947/webrev.02/
Regards
Prasanta
On 9/23/2016 9:47 PM, Philip Race wrote:
The JDK changes are fine but I don't think the test is.
It assumes that the system default is no banner page.
You need to update the test to check what the s
77 throw new RuntimeException("Banner page is printed");
that message needs to be conditionalized too.
-phil
On 9/23/16, 10:01 AM, Prasanta Sadhukhan wrote:
Updated the testcase:
http://cr.openjdk.java.net/~psadhukhan/8165947/webrev.02/
Regards
Prasanta
On 9/23/2016 9:47 PM,
Yes, sorry. Done
http://cr.openjdk.java.net/~psadhukhan/8165947/webrev.03/
Regards
Prasanta
On 9/23/2016 10:44 PM, Philip Race wrote:
77 throw new RuntimeException("Banner page is printed");
that message needs to be conditionalized too.
-phil
On 9/23/16, 10:01 AM, Prasanta S
+1
-phil.
On 9/23/16, 10:24 AM, Prasanta Sadhukhan wrote:
Yes, sorry. Done
http://cr.openjdk.java.net/~psadhukhan/8165947/webrev.03/
Regards
Prasanta
On 9/23/2016 10:44 PM, Philip Race wrote:
77 throw new RuntimeException("Banner page is
printed");
that message needs to be
1) version change is only if the format is incompatible - so no change
there.
2) paths being absent is not a new issue. It has always been the case that a
file is not present on a system at runtime. This was historically very
common. The
implementation should handle this.
-phil.
On 9/23/16, 8
10 matches
Mail list logo
