Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

2016-09-30 Thread Semyon Sadetsky
Thanks! I found this setting very useful. --Semyon On 9/30/2016 6:51 AM, Philip Race wrote: BTW I just noticed in the source code that there is an environment variable that disables the check : see windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp static BOOL bNoHwCheck =

Re: [OpenJDK 2D-Dev] HiDPI support issues on Windows

2016-09-30 Thread Alexandr Scherbatiy
Hello Anton, Yes, we are working on it. For example, there is the known issue DK-8162350 RepaintManager shifts repainted region when the floating point UI scale is used. https://bugs.openjdk.java.net/browse/JDK-8162350 The problem is that the RepaintManager draws a region to a buffered

Re: [OpenJDK 2D-Dev] RFR: 8166981: RGBColorConvertTest has wrong @run line

2016-09-30 Thread Phil Race
Approved. I checked that the test does actually pass since it presumably has not been run by jtreg .. -phil. On 09/30/2016 10:51 AM, Martin Buchholz wrote: https://bugs.openjdk.java.net/browse/JDK-8166981 http://cr.openjdk.java.net/~martin/webrevs/openjdk9/RGBColorConvertTest/

[OpenJDK 2D-Dev] RFR: 8166981: RGBColorConvertTest has wrong @run line

2016-09-30 Thread Martin Buchholz
https://bugs.openjdk.java.net/browse/JDK-8166981 http://cr.openjdk.java.net/~martin/webrevs/openjdk9/RGBColorConvertTest/

Re: [OpenJDK 2D-Dev] RFR: 8166981: RGBColorConvertTest has wrong @run line

2016-09-30 Thread Sergey Bylokhov
On 30.09.16 20:56, Phil Race wrote: Approved. +1 I checked that the test does actually pass since it presumably has not been run by jtreg .. Why it is passed? I wonder how this bug was found? On 09/30/2016 10:51 AM, Martin Buchholz wrote: https://bugs.openjdk.java.net/browse/JDK-8166981

Re: [OpenJDK 2D-Dev] HiDPI support issues on Windows

2016-09-30 Thread Anton Tarasov
Hi Alexandr, > On 30 Sep 2016, at 13:22, Alexandr Scherbatiy > wrote: > > > Hello Anton, > > Yes, we are working on it. > > For example, there is the known issue DK-8162350 RepaintManager shifts > repainted region when the floating point UI scale is used. >

Re: [OpenJDK 2D-Dev] RFR: 8166981: RGBColorConvertTest has wrong @run line

2016-09-30 Thread Martin Buchholz
On Fri, Sep 30, 2016 at 11:10 AM, Sergey Bylokhov < sergey.bylok...@oracle.com> wrote: > On 30.09.16 20:56, Phil Race wrote: > >> Approved. >> > +1 > > >> I checked that the test does actually pass since it presumably has not >> been run by jtreg .. >> > > Why it is passed? I wonder how this bug

Re: [OpenJDK 2D-Dev] HiDPI support issues on Windows

2016-09-30 Thread Jim Graham
On 9/30/16 3:22 AM, Alexandr Scherbatiy wrote: The problem is that the RepaintManager draws a region to a buffered image at first and draws the image after that to the window. Suppose the image has int coordinates and size (x, y, w, h) in the user space. It should be drawn into the region

Re: [OpenJDK 2D-Dev] Request for Review: JDK-8162591 All existing gradient paint implementations have issues with coordinates/sizes larger than Short.MAX_VALUE (exactly) on any Linux systems

2016-09-30 Thread Phil Race
Pushed .. -phil. On 09/28/2016 12:41 PM, Sergey Bylokhov wrote: Thanks. On 28.09.16 8:45, Clemens Eisserer wrote: HI Jim, All of those conditions are optimized equivalents to getting the determinant. invert() is a destructive call, but since getTransform is documented to return a copy,