Re: [OpenJDK 2D-Dev] [9] Review Request: [JDK-8169879] [TEST_BUG] javax/swing/text/GlyphPainter2/6427244/bug6427244.java - compilation failed

2016-11-21 Thread Prasanta Sadhukhan
It seems if user minimize/maximize the frame (which is allowed as per testcase), then the test might fail. I guess we can set the frame to "undecorated" to prevent the user to play with minimize/maximize/close. Also, I am not sure if we can call blockTillDisplayed(tp); outside EDT. Maybe Serg

Re: [OpenJDK 2D-Dev] [9] Review Request: [JDK-8169879] [TEST_BUG] javax/swing/text/GlyphPainter2/6427244/bug6427244.java - compilation failed

2016-11-21 Thread Prahalad Kumar Narayanan
Thank you for your time in review Prasanta. Appreciate your views. As you noticed, I observed test-failures as well ( by simply moving the mouse ) . There are quite some improvements that could be done to this test-case . But we could address them in a new bug . The current b

Re: [OpenJDK 2D-Dev] [9] Review Request: [JDK-8169879] [TEST_BUG] javax/swing/text/GlyphPainter2/6427244/bug6427244.java - compilation failed

2016-11-21 Thread Phil Race
The test does not have the "manual" tag/key so it is intended to be run as an automated test. User interaction will break a lot of automated tests that display a UI. Without looking at the specifics of this one, I'd guess it likely that it just an example of that .. rather than a unique problem.

[OpenJDK 2D-Dev] [9] RFR JDK-8170142: Broken links in TIFF metadata format and usage notes

2016-11-21 Thread Brian Burkhalter
Please review at your earliest convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8170142 Patch: [1] Thanks, Brian [1] diff --- a/src/java.desktop/share/classes/javax/imageio/metadata/doc-files/tiff_metadata.html +++ b/src/java.desktop/share/classes/javax/imageio/metadata/doc-fil

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8170142: Broken links in TIFF metadata format and usage notes

2016-11-21 Thread Brian Burkhalter
Please hold off on this for now, I missed another broken link elsewhere. On Nov 21, 2016, at 1:22 PM, Brian Burkhalter wrote: > Please review at your earliest convenience. > > Issue:https://bugs.openjdk.java.net/browse/JDK-8170142 > Patch:[1] > > Thanks, > > Brian > > [1] di

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8170142: Broken links in TIFF metadata format and usage notes

2016-11-21 Thread Brian Burkhalter
OK, here is a webrev which is hopefully complete this time: http://cr.openjdk.java.net/~bpb/8170142/webrev.00/ Note that the link to a GeoTIFF specification page was simply removed as a reliable target appears difficult to identify now. Thanks, Brian On Nov 21, 2016, at 1:34 PM, Brian Burkhal

[OpenJDK 2D-Dev] RFR: 8167103: Intermittent font loading failure on macOS with JFXPanel application

2016-11-21 Thread Philip Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8167103 Webrev: http://cr.openjdk.java.net/~prr/8167103/ This bug is a deadlock in MacOS platform font code when JavaFX and Java2D are both calling platform font APIs. This can happen in the context of Swing inter-op for FX. It was previously seen whe

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8170142: Broken links in TIFF metadata format and usage notes

2016-11-21 Thread Phil Race
+1 -phil. On 11/21/2016 02:06 PM, Brian Burkhalter wrote: OK, here is a webrev which is hopefully complete this time: http://cr.openjdk.java.net/~bpb/8170142/webrev.00/ Note that the link to a GeoTIFF specification page was simply remov

Re: [OpenJDK 2D-Dev] RFR: 8167103: Intermittent font loading failure on macOS with JFXPanel application

2016-11-21 Thread Sergey Bylokhov
Looks fine, but are you sure that we need such mix of logging in the debug build? 410 #ifdef DEBUG 411 NSLog(@"path is : %@", (NSString*)path); 412 NSLog(@"url is : %@", (NSString*)url); 413 printf("res is %d\n", res); 414 #endif I wonder from the specification of the old method

Re: [OpenJDK 2D-Dev] RFR: 8167103: Intermittent font loading failure on macOS with JFXPanel application

2016-11-21 Thread Philip Race
On 11/21/16, 4:17 PM, Sergey Bylokhov wrote: Looks fine, but are you sure that we need such mix of logging in the debug build? Do you mean "any" logging or the mix in of the printf ? Certainly the ifdef DEBUG pattern is used all over this file .. 410 #ifdef DEBUG 411 NSLog(@"path is :

Re: [OpenJDK 2D-Dev] RFR: 8167103: Intermittent font loading failure on macOS with JFXPanel application

2016-11-21 Thread Sergey Bylokhov
On 22.11.16 5:45, Philip Race wrote: On 11/21/16, 4:17 PM, Sergey Bylokhov wrote: Looks fine, but are you sure that we need such mix of logging in the debug build? Do you mean "any" logging or the mix in of the printf ? Certainly the ifdef DEBUG pattern is used all over this file .. I mean