[OpenJDK 2D-Dev] [9] RFR JDK-8152561: Is it allowed to have zero value for count in TIFFField.createArrayForType() for the rationals

Hello All, Please review the following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8152561 Webrev : http://cr.openjdk.java.net/~jdv/8152561/webrev.00/ Issue : There is difference in how we interpret "count" variable passed to TIFFField.createArrayFo

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8170578: The Pages Range From in print dialog is disabled

I am looking at this and the hold up is I can't remember the protocol readIPPResponse() is trying to follow. Without that understanding it is hard to say much .. so I need to go read up and remember .. Two comments : There is an extra space in if (responseMap.length> 1) { The test update i

Re: [OpenJDK 2D-Dev] [PATCH] Deadlock in CGLGraphicsConfig.getCGLConfigInfo

Thanks Sergey, I’m sorry I didn’t discover this bug somehow! Yes, this bug appears to be the exactly same fault: We can see the Java2D Disposer thread blocked in the same spot as the AWT Event Queue thread was blocked in my examples, and for the same reason: "Java2D Disposer" #1366 daemon prio

[OpenJDK 2D-Dev] Review Request JDK-8172559 [PIT][TEST_BUG] Move @test to be 1st annotation in java/awt/image/Raster/TestChildRasterOp.java

Hi, Please review fix for JDK 9, Bug: https://bugs.openjdk.java.net/browse/JDK-8172559 Webrev: http://cr.openjdk.java.net/~pkbalakr/8172559/webrev.00/ Jtreg Error: Not a test or directory containing tests: java/awt/image/Raster/TestChildRasterOp.java Cause: Wrong order of tag tokens ,

Re: [OpenJDK 2D-Dev] Review Request JDK-8172559 [PIT][TEST_BUG] Move @test to be 1st annotation in java/awt/image/Raster/TestChildRasterOp.java

Looks fine. Regards, Ajit From: Prem Balakrishnan Sent: Thursday, January 12, 2017 11:34 AM To: Ajit Ghaisas; Prasanta Sadhukhan; 2d-dev@openjdk.java.net Subject: Review Request JDK-8172559 [PIT][TEST_BUG] Move @test to be 1st annotation in java/awt/image/Raster/TestChildRasterOp.java

Re: [OpenJDK 2D-Dev] Review Request JDK-8172559 [PIT][TEST_BUG] Move @test to be 1st annotation in java/awt/image/Raster/TestChildRasterOp.java

+1. BTW, append 2017 to copyright year, before pushing. Regards Prasanta On 1/12/2017 11:34 AM, Prem Balakrishnan wrote: Hi, Please review fix for JDK 9, Bug: https://bugs.openjdk.java.net/browse/JDK-8172559 Webrev: http://cr.openjdk.java.net/~pkbalakr/8172559/webrev.00/

Re: [OpenJDK 2D-Dev] Review Request JDK-8172559 [PIT][TEST_BUG] Move @test to be 1st annotation in java/awt/image/Raster/TestChildRasterOp.java

This sounds like a jtreg bug since I don't see this specified. http://openjdk.java.net/jtreg/tag-spec.html -phil On 1/11/17, 10:04 PM, Prem Balakrishnan wrote: Hi, Please review fix for JDK 9, Bug: https://bugs.openjdk.java.net/browse/JDK-8172559 Webrev: http://cr.openjdk.java.net/~pkbalak

Re: [OpenJDK 2D-Dev] [PATCH] Deadlock in CGLGraphicsConfig.getCGLConfigInfo

> On Jan 12, 2017, at 04:22, Karl von Randow wrote: > > I’m sorry I didn’t discover this bug somehow! Who cares?—I really appreciate that you provide a fix after no progress has been made for more than half a year! That’s awesome. -hendrik