Re: [OpenJDK 2D-Dev] JDK-8178091 : Bug I will workin on

2017-04-19 Thread Phil Race
On 04/19/2017 12:51 AM, Patrick Chen wrote: Ok so can you take the source from the git ? Sounds the same to me as reviewing it there .. You probably have an account in cr.openjdk.java.net , but Another solution to fix the bug 8178091 is to write a repaint()

Re: [OpenJDK 2D-Dev] JDK-8178091 : Bug I will workin on

2017-04-19 Thread Patrick Chen
Ok so can you take the source from the git ? You probably have an account in cr.openjdk.java.net , but Another solution to fix the bug 8178091 is to write a repaint() method from Component.java (as we all know : JPanel.java -->(extends) >Jcomponent.java -->(extends)-> Composent.java) and the r

[OpenJDK 2D-Dev] [9] Review request for 8178984: Unnecessary angle brackets in the Line2D::intersectsLine() javadoc.

2017-04-19 Thread Semyon Sadetsky
Hello, Please review the fix for jdk9. bug: https://bugs.openjdk.java.net/browse/JDK-8178984 webrev: http://cr.openjdk.java.net/~ssadetsky/8178984/webrev.00/ Angle brackets around "true" are removed. --Semyon

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

2017-04-19 Thread Prahalad Kumar Narayanan
Hello Laurent The code changes look good. . The new method trimToSize effectively does the same operation (Arrays.copyOf) as done by the copy contructors. . The test file- Path2DCopyConstructor now tests after executing the methods pathObj.trimToSize and pathObj.clone With regard to the

Re: [OpenJDK 2D-Dev] [9] Review request for 8178984: Unnecessary angle brackets in the Line2D::intersectsLine() javadoc.

2017-04-19 Thread Jayathirth D V
Hi Semyon, Changes are fine. Thanks, Jay -Original Message- From: Semyon Sadetsky Sent: Thursday, April 20, 2017 2:27 AM To: 2d-dev@openjdk.java.net Subject: [OpenJDK 2D-Dev] [9] Review request for 8178984: Unnecessary angle brackets in the Line2D::intersectsLine() javadoc. Hello, P

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

2017-04-19 Thread Laurent Bourgès
Hello, Here is an updated webrev: http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.1/ I fixed the copyright dates and the javadoc as you proposed (I initially derived the javadoc from Vector.trimToSize) Thanks, Laurent 2017-04-20 5:46 GMT+02:00 Prahalad Kumar Narayanan < prahalad.kuma