Re: [OpenJDK 2D-Dev] [10] RFR JDK-8189702: Broken links in javadoc for Adobe TIFF related documents

2017-11-03 Thread Jayathirth D V
Hello Phil & Brian, When Phil mentioned about not having proper links from Adobe for TIFF references I thought we should remove all the references to TIFF, so that's why webrev.01 had no references to any of TIFF documentation. I also feel that we should have at least have reference to T

Re: [OpenJDK 2D-Dev] [10] Review Request JDK - 8164811 : [hidpi]Tests fail with OpenGL Rendering

2017-11-03 Thread Pankaj Bansal
Hi Sergey, I have created the BufferedImage of correct size considering the window dimension and graphics context scale. I changed BufferedImage just to store graphicsConfig, so that it can be used by BufImgSurfaceManager while creating BufImgSurfaceData. The scale in BufImgSurfaceData is use

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8189702: Broken links in javadoc for Adobe TIFF related documents

2017-11-03 Thread Brian Burkhalter
Hi Jay, On Nov 3, 2017, at 12:47 AM, Jayathirth D V wrote: > I also feel that we should have at least have reference to TIFF spec and ITU > link seems reasonable. > @Brian : I previously looked > intohttps://www.loc.gov/preservation/digital/formats/fdd/fdd22.shtml#specs > and it has lot o

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8189702: Broken links in javadoc for Adobe TIFF related documents

2017-11-03 Thread Philip Race
+1 -phil. On 11/3/17, 11:42 AM, Brian Burkhalter wrote: Hi Jay, On Nov 3, 2017, at 12:47 AM, Jayathirth D V > wrote: I also feel that we should have at least have reference to TIFF spec and ITU link seems reasonable. @Brian : I previously looked intohttps:

Re: [OpenJDK 2D-Dev] [10] Review Request: 8019816 [TEST_BUG][macosx] closed/java/awt/BasicStroke/DashZeroWidth.java not on EDT

2017-11-03 Thread Philip Race
Approved. -phil. On 11/2/17, 6:43 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk10. Description: The tests were reworked to use only 2d api. The check for VolatileImage is added just to improve code coverage and it is executed only in headful mode. This is a request to move

Re: [OpenJDK 2D-Dev] [10] Review Request JDK - 8164811 : [hidpi]Tests fail with OpenGL Rendering

2017-11-03 Thread Philip Race
Adding new API to BufferedImage was definitely NOT the way to approach this. Adding new public API we need to support forever to fix an internal implementation bug on one platform in a very atypical scenario is the wrong trade-off. And anyway as Sergey said BI should have no dependency or relat