Hello All,
Please review the following fix in JDK10 :
Bug : https://bugs.openjdk.java.net/browse/JDK-8190512
Webrev : http://cr.openjdk.java.net/~jdv/8190512/webrev.00/
Issue : PNGImageReader throws "java.lang.IllegalArgumentException: Empty
region!" when the IHDR width/height value
Hello Jay
The code change looks good to me.
However, I 'm not sure if we could include the test-case here.
The test case contains the Base64 encoded image in a String.
To my knowledge, we cannot import images into JDK (even encoded in String)
unless we are sure of the copyrights.
Thanks
Have a
Hi Prahalad,
Thanks for your review.
I remember using byteArray from test case in JBS previously for one of the fix
so I searched for the same : https://bugs.openjdk.java.net/browse/JDK-8066904
. This is one of the initial issues that I worked on.
I also see that you recently didn't include s
+ 2d-dev, Phil.
Regards,
Pankaj Bansal
-Original Message-
From: Pankaj Bansal
Sent: Friday, November 3, 2017 3:11 PM
To: Sergey Bylokhov; awt-...@openjdk.java.net
Subject: RE: [10] Review Request: JDK-8159142 : Visible artifacts in
sun/java2d/SunGraphics2D/DrawImageBilinear.java
Hi Se
On Wed, Nov 8, 2017 at 12:08 AM, Philip Race wrote:
> bug: https://bugs.openjdk.java.net/browse/JDK-8186306
> webrev: http://cr.openjdk.java.net/~prr/8186306/
>
> This fix removes the pisces rasterizer code since it is superseded by
> marlin.
>
> In addition it removes the (always) un-used Jules c
Hi Jay,
I don’t see anything wrong with using an encoded string if it is not derived
from a copyrighted image: it’s better than checking an image binary into the
SCM. It would be nice however to test for negative height as well in order to
get full coverage.
Thanks,
Brian
On Nov 8, 2017, at
Kevin & Phil,
Some news on that issue:
I successfully managed to finish the Path clipping support in Marlin 0.8.2
(release last week):
https://github.com/bourgesl/marlin-renderer/releases/tag/v0.8.2
I fixed few remaining bugs in either Stroker (1) and in PathClipFilter (2)
to have proper & tested
I think they should be separate webrevs sent to the separate lists and
you should start with 2D
as I can then run the JDK regression tests on it. I know you can
theoretically run the open regression
tests too (are you ?) but there are some random scattered closed
regression tests that so far
as
And once we are happy with the 2D webrev, it should be pretty
straight-forward to review it for FX.
-- Kevin
Phil Race wrote:
I think they should be separate webrevs sent to the separate lists and
you should start with 2D
as I can then run the JDK regression tests on it. I know you can
theor
Hi Brian,
Thanks for your review.
The encoded string present in test case has only the critical chunks, I have
checked and verified the same with Phil also offline and it looks like it
doesn't have any text chunks like iTXt, tEXt, and zTXt which may contain
copyright information. I have sen
10 matches
Mail list logo
