Re: [OpenJDK 2D-Dev] [10] Review Request: 8182410, 8183508, 8181289

2017-11-22 Thread Sergey Bylokhov
If there are no other comments about this review, I'll push the first version(.00) of the fix. On 23/10/2017 14:42, Sergey Bylokhov wrote: Hello, Please review the fix for. 8182410: missing 'title' in api/javax/swing/plaf/synth/doc-files/componentProperties.html 8183508: multi_tsc.html shoul

Re: [OpenJDK 2D-Dev] [10] Review Request: 8182410, 8183508, 8181289

2017-11-22 Thread Semyon Sadetsky
Hi Jon, This is not only about HTML5 spec, I also hardly can find resources that follow your " You are correct that there is no bug here. But a bug was absent before this fix as well. This bug is about following to the HTML5 standards, so let's follow them in full and not to return to this on

Re: [OpenJDK 2D-Dev] [10] Review Request: 8182410, 8183508, 8181289

2017-11-22 Thread Jonathan Gibbons
Semyon, I have reconstructed a very simple, very artificial example to demo the bug. This example uses lots of filler text, but while that is artificial, for sake of recreating a demo, note that the problem first appeared, for real, in real JDK 9 API documentation with extended doc comment

Re: [OpenJDK 2D-Dev] [10] Review Request: 8182410, 8183508, 8181289

2017-11-22 Thread Jonathan Gibbons
Semyon, Using the files I previously posted, I confirm that I see the same display problem on a Mac, using the latest OS (High Sierra) and Safari. I also see the problem on the same Mac, with Firefox 55.0.2 -- Jon On 11/22/2017 02:53 PM, Jonathan Gibbons wrote: Semyon, I have reconstructed

Re: [OpenJDK 2D-Dev] [10] Review Request: 8182410, 8183508, 8181289

2017-11-22 Thread Kevin Rushforth
I can confirm the same behavior that Jon sees with Firefox 57 on Windows 7. The link scrolls to the right place with the link and does not with the link. -- Kevin Jonathan Gibbons wrote: Semyon, Using the files I previously posted, I confirm that I see the same display problem on a Mac,

Re: [OpenJDK 2D-Dev] [10] Review Request: 8182410, 8183508, 8181289

2017-11-22 Thread Semyon Sadetsky
Jon, This is because you have fixed page header. For me it works equally in all browsers. I see no discrepancy between Chrome and Firefox on my Linux platform. I believe that the stylesheet.css you have in those examples does the magic : a[name]:before, a[name]:target, a[id]:before, a[id]:ta

Re: [OpenJDK 2D-Dev] [10] Review Request: 8182410, 8183508, 8181289

2017-11-22 Thread Jonathan Gibbons
Semyon, You may indeed have explained why the behavior as it is, but we cannot and should not link this review with changes to the javadoc stylesheets, when the specific changes in the review are gratuitous and not necessary in the first place. Yes, we may separately, and later, look at how

Re: [OpenJDK 2D-Dev] [10] Review Request: 8182410, 8183508, 8181289

2017-11-22 Thread Semyon Sadetsky
Jon, You shouldn't use empty tag for margins. It looks odd. You can add the same css rule for appropriate element. I don't understand which visual issues you mean. --Semyon On 11/22/2017 07:58 PM, Jonathan Gibbons wrote: Semyon, You may indeed have explained why the behavior as it is, bu