Hello Brian,
Thanks for reviewing the changes.
I am posting updated webrev since I need one more review and approval from
2d-dev list.
Updated webrev for review : http://cr.openjdk.java.net/~jdv/8191073/webrev.02/
Thanks,
Jay
From: Brian Burkhalter
Sent: Tuesday, January 09, 2
Hello Brian
Thank you for your time in review & suggestions.
> BandedSampleModel
> L193-196 and 203-207: In general I think it's better for method-internal
> comments to use the "//" form instead of the "/*.*/" form.
My views:
. I find interspersed use of // and /* */ for multi-line com
Hi Prahalad,
On Jan 9, 2018, at 3:42 AM, Prahalad Kumar Narayanan
wrote:
>> BandedSampleModel
>> L193-196 and 203-207: In general I think it's better for method-internal
>> comments to use the "//" form instead of the "/*.*/" form.
> My views:
> . I find interspersed use of // and /* */
Hi Jay,
+1
Brian
On Jan 8, 2018, at 10:50 PM, Prahalad Kumar Narayanan
wrote:
> The change looks good.
>
> […]
> Please find updated webrev for review:
> http://cr.openjdk.java.net/~jdv/8191174/webrev.02/
Hello Jay
I imported your changes & tested the same.
The change doesn't cause new regressions & attached test case passes.
Looks good.
Thank you
Have a good day
Prahalad N.
- Original Message -
From: Jayathirth D V
Sent: Tuesday, January 09, 2018 2:00 PM
To: Brian Burkhalter; 2d-dev
