Re: [OpenJDK 2D-Dev] [11] RFR JDK-8195131: Dead code removal for changes present in JDK-8176795

2018-02-06 Thread Philip Race
Looks fine. If anyone needs this in the future they can add back this or an overload that does the pre-multiplication. -phil. On 1/18/18, 12:44 PM, Prahalad Kumar Narayanan wrote: Hello Jay I understand that the last argument to XRColor.setColorValues (int pixel, boolean pre) is set to 'true

Re: [OpenJDK 2D-Dev] RFR: JDK-8196803: Fix build warnings in jdk libraries with Xcode 9

2018-02-06 Thread Magnus Ihse Bursie
On 2018-02-05 23:54, Erik Joelsson wrote: When building with Xcode 9, we get some warnings triggered in jdk libraries. This patch tries to fix them. See bug description for more details on each of them. In short the following things are addressed: In src/java.desktop/macosx/native/libosxapp/N

Re: [OpenJDK 2D-Dev] Fwd: [PATCH] Fix compiler warnings with newer GCC 7.2.1

2018-02-06 Thread Indu Bhagat
Thanks. harfbuzz is now fixed upstream. libjpeg has acknowledged the patch for shift-negative-value warnings. Can someone advise on the minor fix in libdt_socket component ? On 02/03/2018 05:47 AM, Philip Race wrote: jpeg + harfbuzz are imported libraries. There's no point in a source fix in

Re: [OpenJDK 2D-Dev] Fwd: [PATCH] Fix compiler warnings with newer GCC 7.2.1

2018-02-06 Thread Chris Plummer
The libdt_socket fix looks fine to me. Is there a bug filed for this? Do you plan on contributing the fix yourself and submitting a webrev for official review? thanks, Chris On 2/6/18 11:00 AM, Indu Bhagat wrote: T

Re: [OpenJDK 2D-Dev] RFR: JDK-8196803: Fix build warnings in jdk libraries with Xcode 9

2018-02-06 Thread Sergey Bylokhov
Hi, Erik. Why XCode 9 was selected? It seems that 9.2 is the latest one. 9.2 produces some additional warnings even after this fix. On 05/02/2018 14:54, Erik Joelsson wrote: When building with Xcode 9, we get some warnings triggered in jdk libraries. This patch tries to fix them. See bug descrip

Re: [OpenJDK 2D-Dev] Fwd: [PATCH] Fix compiler warnings with newer GCC 7.2.1

2018-02-06 Thread Chris Plummer
I filed https://bugs.openjdk.java.net/browse/JDK-8196909. I will get the fix into JDK 11. Chris On 2/6/18 12:06 PM, Chris Plummer wrote: The libdt_socket fix looks fine to me. Is there a bug filed for this? Do you plan

Re: [OpenJDK 2D-Dev] RFR: JDK-8196803: Fix build warnings in jdk libraries with Xcode 9

2018-02-06 Thread Erik Joelsson
Hello, The 9 was just me being sloppy and thinking 9.x, I'm actually using 9.2. These are all the warnings I found in JDK libraries. There are additional ones in other parts of the build which have been dealt with in separate issues. /Erik On 2018-02-06 12:54, Sergey Bylokhov wrote: Hi, E