Hi Sergey & Phil,
Could you review the submitted marlin webrev soon ?
I will revert the tile size change in MarlinProperties (6,7 => 5,5) to
avoid any problem for now: 2 lines fix.
As proposed before, supporting larger tiles in 2d pipelines needs many
small tuning and can be done in follow-up is
Bug: https://bugs.openjdk.java.net/browse/JDK-8193017
Webrev: http://cr.openjdk.java.net/~prr/8193017/index.html
This fix is will make building openjdk somewhat easier as it removes
the dependence on an OpenJDK developer on Windows or Mac going
off and downloading and building freetype source the
Build changes look good.
/Erik
On 2018-03-09 14:10, Phil Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8193017
Webrev: http://cr.openjdk.java.net/~prr/8193017/index.html
This fix is will make building openjdk somewhat easier as it removes
the dependence on an OpenJDK developer on
Hi, Phil
Headers of the new files refer to LICENSE.TXT. Should we import it as well?
On 09/03/2018 14:10, Phil Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8193017
Webrev: http://cr.openjdk.java.net/~prr/8193017/index.html
This fix is will make building openjdk somewhat easier as i
No.
-phil.
On 3/9/18, 3:23 PM, Sergey Bylokhov wrote:
Hi, Phil
Headers of the new files refer to LICENSE.TXT. Should we import it as
well?
On 09/03/2018 14:10, Phil Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8193017
Webrev: http://cr.openjdk.java.net/~prr/8193017/index.html
Just to be clear, I mean we don't import it to each of the source files.
But it is there in the file legal/freetype.md in this webrev.
On 3/9/18, 3:26 PM, Philip Race wrote:
No.
-phil.
On 3/9/18, 3:23 PM, Sergey Bylokhov wrote:
Hi, Phil
Headers of the new files refer to LICENSE.TXT. Should w
I am not an expert here, but the LICENSE.TXT is a little bit different.
It states that "This means that *you* must choose *one* of the two
licenses described below,.".
So I do not know should we select the license and provide the text only
for one or for both.
On 09/03/2018 15:28, Phili
It is correct as is ..
-phil.
On 3/9/18, 3:49 PM, Sergey Bylokhov wrote:
I am not an expert here, but the LICENSE.TXT is a little bit different.
It states that "This means that *you* must choose *one* of the two
licenses described below,.".
So I do not know should we select the license
Hi Phil,
This is a nice change! And will make setting up the windows build env much
easier.
Change itself seems fine at a cursory glance. I also tested the build on
Win7 with VS2013 (before, I used to build with a hand-compiled version of
the freetypelib), and it worked fine.
I attempted to test
