Re: [OpenJDK 2D-Dev] [11] RFR [JDK-6686236] GIF native IIOMetadata assumes characterCellWidth/Height as 2bytes

2018-03-19 Thread Jayathirth D V
Hi Prahalad, Verified the code changes with test case. Change looks fine. Thanks, Jay -Original Message- From: Phil Race Sent: Friday, March 16, 2018 9:21 PM To: Prahalad Kumar Narayanan; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR [JDK-6686236] GIF native IIOMetadata assumes charact

Re: [OpenJDK 2D-Dev] [11] Review Request: 4912693 Behavior of null arguments not specified in Java Sound

2018-03-19 Thread Phil Race
looks good + I have reviewed the CSR. -phil. On 03/17/2018 11:16 PM, Sergey Bylokhov wrote: Hi, Phil. Thank you for review. An updated version: http://cr.openjdk.java.net/~serb/4912693/webrev.02 CSR: https://bugs.openjdk.java.net/browse/JDK-8199763 On 16/03/2018 08:57, Phil Race wrote: - * are

[OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

2018-03-19 Thread Adam Farley8
Hi All, I ask for a committer to add one word to make/lib/Awt2dLibraries.gmk to solve a build break. We need to go to line 495 and add array-bounds into the list of disabled warnings. So this: DISABLED_WARNINGS_gcc := clobbered implicit-fallthrough shift-negative-value, \ becomes this: DI

Re: [OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not supported in BMPImageReader

2018-03-19 Thread Phil Race
Since the principal addition of these formats is to add explicit fields for supporting the bitmasks for accessing R/G/B/A it seems odd to see there is code like this which ignores it when the data is uncompressed by using these hardcoded values : 456 if ((int)compress

[OpenJDK 2D-Dev] RFR 8199789: Emit a warning message when t2k is selected via system property

2018-03-19 Thread Phil Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8199789 Webrev : http://cr.openjdk.java.net/~prr/8199789/ https://bugs.openjdk.java.net/browse/JDK-8193017 made freetype the default font rasteriser for all JDK builds. We plan to remove t2k completely including references to it from open sources, be