Re: [OpenJDK 2D-Dev] RFR: 8191522: Remove references to Lucida fonts from OpenJDK sources

2018-05-17 Thread Philip Race
http://cr.openjdk.java.net/~prr/8191522.1 uploaded. Adding .. the removal of .. a couple of uses of lucida - sanity check of lucida in font config files is no longer needed. - J2DBench demo opts change from lucida to dialog. Not sure why it had lucida anyway .. -phil. On 5/16/18, 4:08 PM, Erik

Re: [OpenJDK 2D-Dev] RFR: 8191522: Remove references to Lucida fonts from OpenJDK sources

2018-05-17 Thread Sergey Bylokhov
Looks fine. On 17/05/2018 16:58, Philip Race wrote: http://cr.openjdk.java.net/~prr/8191522.1 uploaded. Adding .. the removal of .. a couple of uses of lucida - sanity check of lucida in font config files is no longer needed. - J2DBench demo opts change from lucida to dialog. Not sure why it had

Re: [OpenJDK 2D-Dev] RFR: JDK-8187100: support Variation Selectors(Resend)

2018-05-17 Thread Philip Race
There's a lot to think about here but I have some requests to first clean up the proposed code to conform to coding standards. I see lots of lines > 80 chars. Please fix I see if(foo){ and else{ which should be "if (foo) {" and "else {" Basically always have a space before { and after ) and aro

[OpenJDK 2D-Dev] RFR [XS] - 8203355 : MITSHM define guarding missing

2018-05-17 Thread Baesken, Matthias
Please review this minor change that adds a missing #ifdef MITSHM Compile time guarding to X11SurfaceData.c http://cr.openjdk.java.net/~mbaesken/webrevs/8203355.0/ https://bugs.openjdk.java.net/browse/JDK-8203355 Usually one would not run into any problems because of the double-guard