Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

2018-05-18 Thread Adam Farley8
Hi, I tried to use the IJG's contact page, but no joy. Seems broken; there a spinning icon when you hit "send", but nothing happens. http://jpegclub.org/reference/contact/ So I used a slightly older mailing list on sourceforge. The request to update their code has been sent, and I hope it will

Re: [OpenJDK 2D-Dev] RFR [XS] - 8203355 : MITSHM define guarding missing

2018-05-18 Thread Phil Race
Looks fine. -phil. On 05/17/2018 11:49 PM, Baesken, Matthias wrote: Please review this minor change that adds a missing #ifdef MITSHM Compile time guarding to X11SurfaceData.c http://cr.openjdk.java.net/~mbaesken/webrevs/8203355.0/

Re: [OpenJDK 2D-Dev] RFR: JDK-8187100: support Variation Selectors(Resend)

2018-05-18 Thread Toshio 5 Nakamura
Thank you for your review, Phil. I'm working to handle your points. Toshio Nakamura Philip Race wrote on 2018/05/18 13:39:35: > From: Philip Race > To: Toshio 5 Nakamura > Cc: 2d-dev <2d-dev@openjdk.java.net> > Date: 2018/05/18 13:39 > Subject: Re: [OpenJDK 2D-Dev] RFR: JDK-8187100: support V

Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

2018-05-18 Thread Thomas Stüfe
I admire your perseverance :) but I think this is a fools errand. The amount of work you have to put into this far outbalances the amount of work the OpenJDK maintainers would have to spend when (if ever) they were to merge down upstream libjpeg. Note that we have a lot of experience with downstr