Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

2018-10-02 Thread Krishna Addepalli
Yes, that is right. I have compiled it Mac, Linux and Windows locally. I tried submitting a Mach5 job, but was unable to as it was down. Will try it again. Thanks Krishna > On 02-Oct-2018, at 3:39 AM, Philip Race wrote: > > I suspect I understand this one now .. the array is stack allocated so

Re: [OpenJDK 2D-Dev] Rendering images from PDF files slower in OpenJDK

2018-10-02 Thread Laurent Bourgès
Hi Daniel, > > Let's not compare apples and oranges. What I can see it takes the same > route and behave similarly. > I agree, I did not take enough time to get accurate profiles, sorry. > If you look at > http://uhash.com/java_reg/Call_Tree_java_8.html > http://uhash.com/java_reg/Call_Tree_ja

Re: [OpenJDK 2D-Dev] Rendering images from PDF files slower in OpenJDK

2018-10-02 Thread Philip Race
I've spent some time examining what pdfbox is passing to ColorConvertOp It is called about 10 or 11 times in this test with images typically 1-2K in each dimension. The input image is a Custom BufferedImage which uses an ICC_ColorSpace constructed from a color profile file that is embedded in pd

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211055:Provide print to a file (PDF) feature even when printer was not connected

2018-10-02 Thread Philip Race
Good enough to fix the regression. +1 -phil. On 9/26/18, 11:24 PM, Prasanta Sadhukhan wrote: I have added @requires tag and also did an initial check of existing printers and exit if there is any. Regarding setting,retrieving Destination attribute, if we do not show the print dialog and a

Re: [OpenJDK 2D-Dev] RFR JDK-8211300: Convert C-style array declarations in Java code

2018-10-02 Thread Philip Race
Given what Sergey has done, I don't need to repeat that work. I am now just looking for formatting anomalies, but there is a lot to look at. I should be able to OK this tomorrow and we can then commit it on your behalf. Have you looked at the other client modules ? datatransfer, accessibility