Re: [OpenJDK 2D-Dev] [12] Review Request: 8212790 Javadoc cleanup of java.awt.color package

2018-10-25 Thread Krishna Addepalli
+1 Krishna > On 25-Oct-2018, at 10:06 AM, Sergey Bylokhov > wrote: > > Hi, Krishna. > Thank you for review! > >> 1894, 1895, 1902, 1904. > The text on the lines above is a block comment not a javadoc, the tags are > not necessary there. > >> 1570, 1601, > > I have fixed these: > http://cr

Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails

2018-10-25 Thread Prasanta Sadhukhan
Hi Fairoz, Do you know if the bmp image file has Oracle copyright? If not, you cannot check it in. Alternatively, you may get a hexdump of the bmp file and create a byte[] array with that hex data and create ByteArrayInputStream with that and use that for ImageIO as an ImageInputStream. Rega