[OpenJDK 2D-Dev] RFR: 6573239: Typo in jfc text file

2019-06-06 Thread Andrey Turbanov
Hello. I would like to contribute a small patch for bug: https://bugs.openjdk.java.net/browse/JDK-6573239 Please review and sponsor. Index: src/demo/share/jfc/SwingSet2/resources/tree.txt IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8

Re: [OpenJDK 2D-Dev] RFR: 8217731: Font rendering and glyph spacing changed from jdk-8 to jdk-11

2019-06-06 Thread semyon . sadetsky
On 6/6/19 9:12 AM, Phil Race wrote: On 6/6/19 9:11 AM, semyon.sadet...@oracle.com wrote: On 6/5/19 6:43 PM, Philip Race wrote: On 6/5/19, 4:18 PM, Semyon Sadetsky wrote: On 6/5/19 2:11 PM, Phil Race wrote: It *can* make a difference and in fact we have a regression test that now

Re: [OpenJDK 2D-Dev] [13] RFR JDK-8225368:broken links in java.desktop files

2019-06-06 Thread Jonathan Gibbons
You should be able to link to public API in other modules. There was an issue with hard-coded '` links when javadoc added the extra level of module directory into the output hierarchy, but those issues have now been sorted out. -- Jon On 06/06/2019 05:31 PM, Sergey Bylokhov wrote: On

Re: [OpenJDK 2D-Dev] [13] RFR JDK-8225368:broken links in java.desktop files

2019-06-06 Thread Sergey Bylokhov
On 06/06/2019 12:50, Jonathan Gibbons wrote: You should be able to use {@link} to refer to other Java elements; It is possible even across the different modules?(I remember there was some related issue) -- Jon On 06/06/2019 12:46 PM, Sergey Bylokhov wrote: Hi, Prasanta. Can you please

Re: [OpenJDK 2D-Dev] RFR: 6573239: Typo in jfc text file

2019-06-06 Thread Philip Race
1) I think this should be sent to the swing list, swing-dev since these are swing demos AND there's a change in Swing product code. 2) Please *subscribe* to the lists before posting, else your mail will be blocked 3) Please sign and return the OCA to make contributions. These changes are

Re: [OpenJDK 2D-Dev] RFR: 8217731: Font rendering and glyph spacing changed from jdk-8 to jdk-11

2019-06-06 Thread semyon . sadetsky
On 6/5/19 6:43 PM, Philip Race wrote: On 6/5/19, 4:18 PM, Semyon Sadetsky wrote: On 6/5/19 2:11 PM, Phil Race wrote: It *can* make a difference and in fact we have a regression test that now passes with this fix which tests different rendering modes. Which test is it? Why you didn't mark

Re: [OpenJDK 2D-Dev] RFR: 8217731: Font rendering and glyph spacing changed from jdk-8 to jdk-11

2019-06-06 Thread Phil Race
On 6/6/19 9:11 AM, semyon.sadet...@oracle.com wrote: On 6/5/19 6:43 PM, Philip Race wrote: On 6/5/19, 4:18 PM, Semyon Sadetsky wrote: On 6/5/19 2:11 PM, Phil Race wrote: It *can* make a difference and in fact we have a regression test that now passes with this fix which tests different

[OpenJDK 2D-Dev] [13] RFR JDK-8225368:broken links in java.desktop files

2019-06-06 Thread Prasanta Sadhukhan
Hi All, Please review a doc-fix to fix broken links in java.desktop files Bug: https://bugs.openjdk.java.net/browse/JDK-8225368 webrev: http://cr.openjdk.java.net/~psadhukhan/8225368/webrev.0/ Regards Prasanta

Re: [OpenJDK 2D-Dev] [13] RFR JDK-8225368:broken links in java.desktop files

2019-06-06 Thread Sergey Bylokhov
Hi, Prasanta. Can you please double check is it possible to use {@link } instead of in the java files? For example in src/java.desktop/share/classes/javax/print/attribute/package-info.java Note that some of these docs use 80 chars per line alignment, please use the same style. On

Re: [OpenJDK 2D-Dev] [13] RFR JDK-8225368:broken links in java.desktop files

2019-06-06 Thread Jonathan Gibbons
Sergey, Prasanta, You should be able to use {@link} to refer to other Java elements;  you cannot (yet) use {@link} to link to user-defined anchors in other files (but it's on the list) -- Jon On 06/06/2019 12:46 PM, Sergey Bylokhov wrote: Hi, Prasanta. Can you please double check is it