Re: [OpenJDK 2D-Dev] [14] RFR JDK-8235147: Release HDC from passiveDCList sooner

2019-12-04 Thread Alexey Ivanov
On 04/12/2019 02:29, Sergey Bylokhov wrote: On 12/2/19 2:45 am, Alexey Ivanov wrote: We can have two different functions though: ReleaseActiveDCs(HWND); ReleasePassiveDCs();> Then we can drop the list parameter. What do you think? Yes, it is worth to try. BTW it would be good to know do we re

Re: [OpenJDK 2D-Dev] [14] RFR JDK-8235147: Release HDC from passiveDCList sooner

2019-12-04 Thread Sergey Bylokhov
On 12/4/19 6:06 am, Alexey Ivanov wrote: Yes, we still need passiveDCList. A DC can be moved to the passive list by DisposeThreadGraphicsInfo function in GDIWindowSurfaceData.cpp. This is called not on the toolkit thread, so we have to defer releasing the DC in this case. However, I agree, we

Re: [OpenJDK 2D-Dev] RFR: 8209113 : Use WeakReference for lastFontStrike for created Fonts

2019-12-04 Thread Sergey Bylokhov
Looks fine, the only suggestion is to use Integer.getInteger(String nm, Integer val) instead of try{Integer.parseInt}catch{} On 11/27/19 1:42 pm, Phil Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8209113 Webrev: http://cr.

Re: [OpenJDK 2D-Dev] RFR: 8234784: Update jpeg.md to reflect code used by JDK

2019-12-04 Thread Sergey Bylokhov
Looks fine. On 11/26/19 1:38 pm, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8234784 Webrev : http://cr.openjdk.java.net/~prr/8234784/ This is a change to the legal attribution file for JPEG. - Adds several contributors - Removes mention of components of the library that are

Re: [OpenJDK 2D-Dev] RFR: 8214481: freetype path does not disable TrueType hinting with AA+FM hints

2019-12-04 Thread Sergey Bylokhov
+1 On 11/28/19 12:49 am, Prasanta Sadhukhan wrote: looks good to me. Regards Prasanta On 28-Nov-19 1:30 AM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8214481 Webrev: http://cr.openjdk.java.net/~prr/8214481/ This is a small change  so that when the RenderingHints for tex

Re: [OpenJDK 2D-Dev] RFR: 8209113 : Use WeakReference for lastFontStrike for created Fonts

2019-12-04 Thread Philip Race
That is equivalent, just syntactic, so no issue there. Any other reviewers ? This needs two. -phil. On 12/4/19, 2:39 PM, Sergey Bylokhov wrote: Looks fine, the only suggestion is to use Integer.getInteger(String nm, Integer val) instead of try{Integer.parseInt}catch{} On 11/27/19 1:42

Re: [OpenJDK 2D-Dev] RFR: 8209113 : Use WeakReference for lastFontStrike for created Fonts

2019-12-04 Thread Jayathirth Rao D V
+1. Thanks, Jay On 05/12/19, 10:14 AM, "2d-dev on behalf of Philip Race" <2d-dev-boun...@openjdk.java.net on behalf of philip.r...@oracle.com> wrote: That is equivalent, just syntactic, so no issue there. Any other reviewers ? This needs two. -phil. On 12/4/19, 2