Re: [OpenJDK 2D-Dev] RFR: 8238942: Rendering artifacts with LCD text and fractional metrics

2020-02-12 Thread Philip Race
Ignore the comment. I should have deleted that (and will before pushing). Since we are adding padding on the left, to render the rightmost pixel of the unpadded image, we need to extend the width by one pixel. But the padding means that the image (as seen by the user) is now being rendered one p

[OpenJDK 2D-Dev] RFR: 8238842: AIOOBE in GIFImageReader.initializeStringTable

2020-02-12 Thread Phil Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8238842 Webrev: http://cr.openjdk.java.net/~prr/8238842/ The string table has a maximum size of 4096 - by GIF spec as well as in the implementation The value initCodeSize (as a power of 2) to initialise the string table, and since GIF only allows 8

Re: [OpenJDK 2D-Dev] RFR: 8238842: AIOOBE in GIFImageReader.initializeStringTable

2020-02-12 Thread Brian Burkhalter
> On Feb 12, 2020, at 11:25 AM, Phil Race wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8238842 > > Webrev: http://cr.openjdk.java.net/~prr/8238842/ > > > The string table has a maximum s

Re: [OpenJDK 2D-Dev] RFR: 8238842: AIOOBE in GIFImageReader.initializeStringTable

2020-02-12 Thread Phil Race
> I assume the test fails without the source change. Yes, it fails without the fix. Also I should mention I ran all our Image I/O regression tests and they all pass. Of course only some fraction of those test the GIF decoding path. -phil. On 2/12/2020 11:55 AM, Brian Burkhalter wrote: On

Re: [OpenJDK 2D-Dev] RFR: 8238942: Rendering artifacts with LCD text and fractional metrics

2020-02-12 Thread Sergey Bylokhov
Ok, looks fine. On 2/12/20 7:10 am, Philip Race wrote: Ignore the comment. I should have deleted that (and will before pushing). Since we are adding padding on the left, to render the rightmost pixel of the unpadded image, we need to extend the width by one pixel. But the padding means that th

Re: [OpenJDK 2D-Dev] RFR: 8238842: AIOOBE in GIFImageReader.initializeStringTable

2020-02-12 Thread Sergey Bylokhov
+1 On 2/12/20 12:07 pm, Phil Race wrote: > I assume the test fails without the source change. Yes, it fails without the fix. Also I should mention I ran all our Image I/O regression tests and they all pass. Of course only some fraction of those test the GIF decoding path. -phil. On 2/12/20