Re: [OpenJDK 2D-Dev] [15] Review Request: 8238075 [OGL] Delete unused properties

2020-03-11 Thread Alexander Zuev
Looks Ok to me. On 29-Jan-20 7:15, Sergey Bylokhov wrote: Hello. Please review the small cleanup for JDK 15. Bug: https://bugs.openjdk.java.net/browse/JDK-8238075 Fix: http://cr.openjdk.java.net/~serb/8238075/webrev.00 The OGL pipeline on macOS still used some properties:  - CGLGraphicsConfig#

Re: [OpenJDK 2D-Dev] [15] Review Request: 8237746 Fixing compiler warnings in src/demo/share/jfc

2020-03-11 Thread Alexey Ivanov
Hi Sergey, The updated webrev.01 looks good to me. Please go ahead and push the changes. I agree with Alexander, separate issues for formatting are better. Regards, Alexey On 11/03/2020 00:12, Sergey Bylokhov wrote: I plan to push this change if there are no more comments about the webrev.

Re: [OpenJDK 2D-Dev] [15] Review Request: 8237746 Fixing compiler warnings in src/demo/share/jfc

2020-03-11 Thread Alexey Ivanov
Thank you to Marc for updating webrev and to Sergey for uploading it. The changes look fine to me as I already stated. I just wanted to share more comments: On 22/02/2020 09:50, Sergey Bylokhov wrote: Thank you, an updated version is upload: http://cr.openjdk.java.net/~serb/8237746/webrev.01

Re: [OpenJDK 2D-Dev] [15] Review Request: 8237746 Fixing compiler warnings in src/demo/share/jfc

2020-03-11 Thread Marc Hoffmann
Hi Alexey, I’m happy to add more small fixes at a later point in time. Please understand that I’m not a Swing expert. But I could help to make the code look cleaner and more like modern Java. Also I think the example code is used in some regression tests, right? So I need to make sure not to b