Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

2020-04-10 Thread Philip Race
On 4/9/20, 10:26 PM, Jayathirth D v wrote: Hi Phil, I went through all use cases captured in test case (TextLayout, draw). With updated change there is difference in behaviour between how we interpret non-invertible transform between TextLayout.draw() and draw() API’s. In case of Te

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

2020-04-10 Thread Philip Race
Oh and if you do draw it, it still goes through the GV path so nothing should draw there. This is what I meant by : > Subsequent rendering of the TextLayoutwill be handled by the other checks being added. The shape returned might be not be null but I don't think you'll get more than a line .

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

2020-04-10 Thread Jayathirth D v
Hi Phil, I see your point of allowing queries on text layout without throwing exceptions. I was also under the impression that we should not see text getting drawn when we try to draw it using TextLayout with your change. For more clarification I am adding what I tested : I used code from your

Re: [OpenJDK 2D-Dev] RFR: 8241493 [macos] Swing PrintDialog attributes issues

2020-04-10 Thread Philip Race
Could you describe here the ideas behind your fix and what the implications are 1) I'm sure I've seen printers that describe the same paper size by multiple names. Why is it a problem here ? If it is because we have the same display name, is that just for known standard sizes ? Can we get the

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

2020-04-10 Thread Philip Race
You're right. This is because I did not apply the non-invertible transform on the graphics and do what would be more normal which is to call Graphics2D.getFontRenderContext() to create the TextLayout so that it matched. The constructor FRC is for layout not rendering. So in other words unless t

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

2020-04-10 Thread Philip Race
You're right. This is because I did not apply the non-invertible transform on the graphics and do what would be more normal which is to call Graphics2D.getFontRenderContext() to create the TextLayout so that it matched. The constructor FRC is for layout not rendering. So in other words unless t

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

2020-04-10 Thread Philip Race
Sorry for the resend - my mailer claimed it had failed ! -phil.