[OpenJDK 2D-Dev] RFR (XS) 8250605: Linux x86_32 builds fail after JDK-8249821

2020-07-27 Thread Aleksey Shipilev
Bug: https://bugs.openjdk.java.net/browse/JDK-8250605 I believe this happens because int-to-pointer-cast is now enabled for libfontmanager. Below is the minimal fix, but I wonder if we should reinstate the disabled warning for clang (in the same manner) and msvc (which warning code that one is

Re: [OpenJDK 2D-Dev] RFR (XS) 8250605: Linux x86_32 builds fail after JDK-8249821

2020-07-27 Thread Erik Joelsson
Looks good to me. /Erik On 2020-07-27 00:28, Aleksey Shipilev wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8250605 I believe this happens because int-to-pointer-cast is now enabled for libfontmanager. Below is the minimal fix, but I wonder if we should reinstate the disabled warnin

Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

2020-07-27 Thread Philip Race
Hi, You're avoiding a crash but I don't yet know what *exactly* caused the crash. Some Java code not handling DEFAULT_CHARSET is obviously not the exact cause. This just starts it and something bad presumably happens later in native code. And I don't yet understand why (we think) this starte

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

2020-07-27 Thread Philip Race
+1 -phil. On 7/26/20, 9:20 PM, Prasanta Sadhukhan wrote: Hi Phil, On 24-Jul-20 3:48 AM, Philip Race wrote: So the bug is that directly calling ServiceUI.printDialog() was enabling a non-functional properties button on just the Windows platform and you are adding an extra condition to preven

Re: [OpenJDK 2D-Dev] RFR (XS) 8250605: Linux x86_32 builds fail after JDK-8249821

2020-07-27 Thread Philip Race
OK .. although I hope to come back in JDK 16 and eliminate all disabled warnings from the now much smaller libfontmanager : https://bugs.openjdk.java.net/browse/JDK-8074844 -phil. On 7/27/20, 5:41 AM, Erik Joelsson wrote: Looks good to me. /Erik On 2020-07-27 00:28, Aleksey Shipilev wrote:

Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

2020-07-27 Thread Yasumasa Suenaga
Hi Phil, I confirmed WFontConfiguration::findFontWithCharset cannot find if -Dfile.encoding=UTF-8 is passed. I guess one of the cause is the definitions in make/data/fontconfig/windows.fontconfig.properties, but also DEFAULT_CHARSET does not work at this point. If we do not pass -Dfile.encodi

Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

2020-07-27 Thread Philip Race
This did start when we updated the fontconfiguration file but I think there was nothing wrong with the update and I found it could happen with the previous  version if we just remove "devanagari" from this line in the OLD version. sequence.allfonts.UTF-8.ja=alphabetic,japanese,devanagari,dingba

Re: [OpenJDK 2D-Dev] RFR: 8166038 BufferedImage methods getTileGridXOffset() and getTileGridYOffset() return a non 0 value for sub images

2020-07-27 Thread Sergey Bylokhov
The new version of the fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8166038 Fix: http://cr.openjdk.java.net/~serb/8166038/webrev.02 In the new version, the test was updated based on the feedback. On 01.04.2020 19:51, Sergey Bylokhov wrote: Hello. Please review the fix for jdk/client. Bu

[OpenJDK 2D-Dev] RFR: 7183828 Invalid Image Variant when using anything other than BufferedImage

2020-07-27 Thread Sergey Bylokhov
Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-7183828 Fix: http://cr.openjdk.java.net/~serb/7183828/webrev.00 Our DrawImage pipe, used as low-level machinery to draw the known type of images, supports only three types of images: - ToolkitImage - imp

Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

2020-07-27 Thread Philip Race
I do see some case when default is being returned. subsetEncodingMap.put("alphabetic", "default"); which then needs an alphabetic font as part of the core script sequence. Now looking at desc.isDefaultFont() && charset.equals("DEFAULT_CHARSET") Perhaps that could change the answer in some cases