Re: [OpenJDK 2D-Dev] RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop [v2]

2020-12-15 Thread Andrey Turbanov
> There are few places in code where manual `while` loop is used with > `Iterator` to iterate over `Collection`. > Instead of manual `while` cycles it's preferred to use _enhanced-for_ cycle > instead: it's less verbose, makes code easier to read and it's less > error-prone. > It doesn't have an

Re: [OpenJDK 2D-Dev] RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop

2020-12-15 Thread Andrey Turbanov
On Mon, 14 Dec 2020 20:04:05 GMT, Phil Race wrote: >> I've added few words in description. >> >> About testing: as I can see testing is done via Github Actions. tier1 builds >> are ok. > >> I've added few words in description. >> >> About testing: as I can see testing is done via Github Action

Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image [v3]

2020-12-15 Thread Magnus Ihse Bursie
On Mon, 30 Nov 2020 17:53:26 GMT, Andrii Rodionov wrote: >> The following PR fixes https://bugs.openjdk.java.net/browse/JDK-8254024 >> >> Starting from version 11.0.9, all JDK libraries also build as static >> libraries (JEP 178: Statically-Linked JNI Libraries). >> The purpose of using static

Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image [v3]

2020-12-15 Thread Phil Race
On Tue, 15 Dec 2020 20:58:44 GMT, Magnus Ihse Bursie wrote: >> Andrii Rodionov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native >> Imag

Re: [OpenJDK 2D-Dev] RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop

2020-12-15 Thread Phil Race
On Tue, 15 Dec 2020 17:14:11 GMT, Andrey Turbanov wrote: >>> I've added few words in description. >>> >>> About testing: as I can see testing is done via Github Actions. tier1 >>> builds are ok. >> >> OK that's better But about testing. The github actions won't run a single >> test that touc

Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image [v3]

2020-12-15 Thread Bob Vandette
On Mon, 30 Nov 2020 17:53:26 GMT, Andrii Rodionov wrote: >> The following PR fixes https://bugs.openjdk.java.net/browse/JDK-8254024 >> >> Starting from version 11.0.9, all JDK libraries also build as static >> libraries (JEP 178: Statically-Linked JNI Libraries). >> The purpose of using static

[OpenJDK 2D-Dev] Integrated: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-12-15 Thread Andrii Rodionov
On Thu, 8 Oct 2020 12:57:29 GMT, Andrii Rodionov wrote: > The following PR fixes https://bugs.openjdk.java.net/browse/JDK-8254024 > > Starting from version 11.0.9, all JDK libraries also build as static > libraries (JEP 178: Statically-Linked JNI Libraries). > The purpose of using static libra

Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v3]

2020-12-15 Thread Magnus Ihse Bursie
> A lot (but not all) of the data in make/data is tied to a specific module. > For instance, the publicsuffixlist is used by java.base, and fontconfig by > java.desktop. (A few directories, like mainmanifest, is *actually* used by > make for the whole build.) > > These data files should move t

Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v4]

2020-12-15 Thread Magnus Ihse Bursie
> A lot (but not all) of the data in make/data is tied to a specific module. > For instance, the publicsuffixlist is used by java.base, and fontconfig by > java.desktop. (A few directories, like mainmanifest, is *actually* used by > make for the whole build.) > > These data files should move t

Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-15 Thread Magnus Ihse Bursie
On Thu, 10 Dec 2020 23:07:52 GMT, Naoto Sato wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move to share/data, and move jdwp.spec to java.se > > Reviewed changes to `characterdata`, `charsetmapping`, `cldr`