[OpenJDK 2D-Dev] RFR: 6211242: AreaAveragingScaleFilter(int, int): IAE is not specified

2021-02-08 Thread Prasanta Sadhukhan
Constructor AreaAveragingScaleFilter(int, int) for java.awt.image.AreaAveragingScaleFilter class throws IllegalArgumentException when 0 is passed for width,height but it's not specified in the spec. Updated spec to illustrate this. - Commit messages: - Fix - Fix - 6211242: AreaAv

Re: [OpenJDK 2D-Dev] RFR: 6211242: AreaAveragingScaleFilter(int, int): IAE is not specified

2021-02-08 Thread Alexander Zvegintsev
On Mon, 8 Feb 2021 09:30:02 GMT, Prasanta Sadhukhan wrote: > Constructor AreaAveragingScaleFilter(int, int) for > java.awt.image.AreaAveragingScaleFilter class throws IllegalArgumentException > when 0 is passed for width,height but it's not specified in the spec. > Updated spec to illustrate t

Re: [OpenJDK 2D-Dev] RFR: 6211242: AreaAveragingScaleFilter(int, int): IAE is not specified

2021-02-08 Thread Tejpal Rebari
On Mon, 8 Feb 2021 09:30:02 GMT, Prasanta Sadhukhan wrote: > Constructor AreaAveragingScaleFilter(int, int) for > java.awt.image.AreaAveragingScaleFilter class throws IllegalArgumentException > when 0 is passed for width,height but it's not specified in the spec. > Updated spec to illustrate t

Re: [OpenJDK 2D-Dev] RFR: 6211198: ICC_Profile.getInstance(byte[]): IAE is not specified [v2]

2021-02-08 Thread Pankaj Bansal
On Sat, 6 Feb 2021 07:05:05 GMT, Sergey Bylokhov wrote: >> The specification of the java.awt.color.ICC_Profile.getInstance(byte[]) is >> updated. >> Its implementation changed over time, and different exceptions were thrown, >> but since JDK-8013430 always throws an IllegalArgumentException on

Re: [OpenJDK 2D-Dev] RFR: 6211257: BasicStroke.createStrokedShape(Shape): NPE is not specified [v3]

2021-02-08 Thread Alexey Ivanov
On Sun, 7 Feb 2021 09:18:04 GMT, Prasanta Sadhukhan wrote: >> Method createStrokedShape(Shape) for java.awt.BasicStroke class throws >> NullPointerException when passed a null object reference for a input >> parameter but it's not specified in the spec. >> Updated spec to illustrate this. > >

Re: [OpenJDK 2D-Dev] RFR: 6211257: BasicStroke.createStrokedShape(Shape): NPE is not specified [v4]

2021-02-08 Thread Prasanta Sadhukhan
> Method createStrokedShape(Shape) for java.awt.BasicStroke class throws > NullPointerException when passed a null object reference for a input > parameter but it's not specified in the spec. > Updated spec to illustrate this. Prasanta Sadhukhan has updated the pull request incrementally with on

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v3]

2021-02-08 Thread Ajit Ghaisas
> **Description :** > This is the implementation of [JEP 382 : New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) > It implements a Java 2D internal rendering pipeline for macOS using the Apple > Metal API. > The entire work on this was done under [OpenJDK Project -

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v3]

2021-02-08 Thread Ajit Ghaisas
On Fri, 5 Feb 2021 18:42:02 GMT, Kevin Rushforth wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Lanai PR#175 - 8261304 - aghaisas > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 894: > >> 892: SHADERS

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v3]

2021-02-08 Thread Kevin Rushforth
On Mon, 8 Feb 2021 13:40:22 GMT, Ajit Ghaisas wrote: >> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 894: >> >>> 892: SHADERS_SUPPORT_DIR := >>> $(SUPPORT_OUTPUTDIR)/native/java.desktop/libosxui >>> 893: SHADERS_AIR := $(SHADERS_SUPPORT_DIR)/shaders.air >>> 894: SHADERS_LIB := $(

Re: [OpenJDK 2D-Dev] RFR: 8261282: Lazy initialization of built-in ICC_Profile/ColorSpace classes is too lazy

2021-02-08 Thread Alexander Zvegintsev
On Sun, 7 Feb 2021 05:36:52 GMT, Sergey Bylokhov wrote: > Short fix description: > > The fix changes the initialization of the built-in color profiles/spaces from > the lazy initialization per requested profile via static synchronization to > the lazy initialization of all profiles/spaces on t

Re: [OpenJDK 2D-Dev] RFR: 6211257: BasicStroke.createStrokedShape(Shape): NPE is not specified [v4]

2021-02-08 Thread Sergey Bylokhov
On Mon, 8 Feb 2021 11:55:09 GMT, Prasanta Sadhukhan wrote: >> Method createStrokedShape(Shape) for java.awt.BasicStroke class throws >> NullPointerException when passed a null object reference for a input >> parameter but it's not specified in the spec. >> Updated spec to illustrate this. > >

Re: [OpenJDK 2D-Dev] RFR: 6211242: AreaAveragingScaleFilter(int, int): IAE is not specified

2021-02-08 Thread Sergey Bylokhov
On Mon, 8 Feb 2021 09:30:02 GMT, Prasanta Sadhukhan wrote: > Constructor AreaAveragingScaleFilter(int, int) for > java.awt.image.AreaAveragingScaleFilter class throws IllegalArgumentException > when 0 is passed for width,height but it's not specified in the spec. > Updated spec to illustrate t

Re: [OpenJDK 2D-Dev] RFR: 8261231: Windows IME was disabled after DnD operation

2021-02-08 Thread Alexander Zuev
On Sun, 7 Feb 2021 08:29:57 GMT, Dmitry Markov wrote: > The function InvokeInputMethodFunction() is responsible for invocation of IME > API. Typically it uses PostMessage() to execute corresponding IME function on > the toolkit thread but if DnD operation takes place SendMessage() is used. > T

Re: [OpenJDK 2D-Dev] RFR: 8261231: Windows IME was disabled after DnD operation

2021-02-08 Thread Ichiroh Takiguchi
On Mon, 8 Feb 2021 16:51:21 GMT, Alexander Zuev wrote: >> The function InvokeInputMethodFunction() is responsible for invocation of >> IME API. Typically it uses PostMessage() to execute corresponding IME >> function on the toolkit thread but if DnD operation takes place >> SendMessage() is us

Re: [OpenJDK 2D-Dev] RFR: 8261231: Windows IME was disabled after DnD operation

2021-02-08 Thread Sergey Bylokhov
On Sun, 7 Feb 2021 08:29:57 GMT, Dmitry Markov wrote: > The function InvokeInputMethodFunction() is responsible for invocation of IME > API. Typically it uses PostMessage() to execute corresponding IME function on > the toolkit thread but if DnD operation takes place SendMessage() is used. > T

Re: [OpenJDK 2D-Dev] RFR: 8261231: Windows IME was disabled after DnD operation

2021-02-08 Thread Dmitry Markov
On Mon, 8 Feb 2021 16:51:21 GMT, Alexander Zuev wrote: > Change looks good and i haven't found any side-effects during testing. Could > you please add the label to the bug noting reason for absence of the > regression test, like noreg-hard or something? Thank you for the review. I have added n

[OpenJDK 2D-Dev] Integrated: 8261231: Windows IME was disabled after DnD operation

2021-02-08 Thread Dmitry Markov
On Sun, 7 Feb 2021 08:29:57 GMT, Dmitry Markov wrote: > The function InvokeInputMethodFunction() is responsible for invocation of IME > API. Typically it uses PostMessage() to execute corresponding IME function on > the toolkit thread but if DnD operation takes place SendMessage() is used. > T

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v3]

2021-02-08 Thread Gerard Ziemski
On Sat, 6 Feb 2021 00:53:08 GMT, Kevin Rushforth wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Lanai PR#175 - 8261304 - aghaisas > > The file in `RenderPerfTest` should have a GPLv2 license header (no > Classpat

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v3]

2021-02-08 Thread Gerard Ziemski
On Mon, 8 Feb 2021 17:15:25 GMT, Gerard Ziemski wrote: >> The file in `RenderPerfTest` should have a GPLv2 license header (no >> Classpath). I filed >> [JDK-8261273](https://bugs.openjdk.java.net/browse/JDK-8261273) and also >> highlighted a couple examples below. > > General comment - I am no

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v3]

2021-02-08 Thread Kevin Rushforth
On Mon, 8 Feb 2021 17:15:25 GMT, Gerard Ziemski wrote: > General comment - I am not sure I like the `MTL` prefix acronym in names (ex. > `sun.java2d.metal.MTLVolatileSurfaceManager`). > > I think you tried to match the `CGL`, but that is a real acronym that stands > for "Core Graphics Layer" (

Re: [OpenJDK 2D-Dev] RFR: 6211198: ICC_Profile.getInstance(byte[]): IAE is not specified [v3]

2021-02-08 Thread Sergey Bylokhov
> The specification of the java.awt.color.ICC_Profile.getInstance(byte[]) is > updated. > Its implementation changed over time, and different exceptions were thrown, > but since JDK-8013430 always throws an IllegalArgumentException on null and > invalid data. Sergey Bylokhov has updated the pul

Re: [OpenJDK 2D-Dev] RFR: 6211198: ICC_Profile.getInstance(byte[]): IAE is not specified [v2]

2021-02-08 Thread Sergey Bylokhov
On Sun, 7 Feb 2021 18:35:31 GMT, Phil Race wrote: >> Sergey Bylokhov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v3]

2021-02-08 Thread Gerard Ziemski
On Mon, 8 Feb 2021 12:28:07 GMT, Ajit Ghaisas wrote: >> **Description :** >> This is the implementation of [JEP 382 : New macOS Rendering >> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) >> It implements a Java 2D internal rendering pipeline for macOS using the >> Apple Metal API.

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v3]

2021-02-08 Thread Gerard Ziemski
On Mon, 8 Feb 2021 12:28:07 GMT, Ajit Ghaisas wrote: >> **Description :** >> This is the implementation of [JEP 382 : New macOS Rendering >> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) >> It implements a Java 2D internal rendering pipeline for macOS using the >> Apple Metal API.

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v3]

2021-02-08 Thread Ajit Ghaisas
On Mon, 8 Feb 2021 14:22:27 GMT, Kevin Rushforth wrote: >> I think, a generic name is OK as the path of shader file already has both >> awt (libawt_lwawt) and java2d in it. > > In the source tree, yes, but not in the jdk image where it ends up in > `$JAVA_HOME/lib/shaders.metallib`. I don't hav