On Fri, 5 Feb 2021 16:07:09 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
The API doc for Graphics2D.clip(shape s) claims that passing a null argument
would actually clear the existing clipping area, which is incorrect.
This statement is applicable only to G2D.setClip() and not for the clip()
method. G2D.clip() would throw a NullPointerException when it encounters a nu
> **Description :**
> This is the implementation of [JEP 382 : New macOS Rendering
> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
> It implements a Java 2D internal rendering pipeline for macOS using the Apple
> Metal API.
> The entire work on this was done under [OpenJDK Project -
On Tue, 9 Feb 2021 11:57:44 GMT, Prasanta Sadhukhan
wrote:
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
> method.
On Tue, 9 Feb 2021 12:48:44 GMT, Alexander Zvegintsev
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>> m
On Tue, 9 Feb 2021 12:52:55 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/java/awt/Graphics2D.java line 1206:
>>
>>> 1204: * @param s the {@code Shape} to be intersected with the current
>>> 1205: * {@code Clip}.
>>> 1206: * @throws NullPointerExceptio
On Tue, 9 Feb 2021 12:54:26 GMT, Prasanta Sadhukhan
wrote:
>> The spec says "s - the Shape to be intersected with the current Clip" so I
>> assume it means there should be a current clip set, so that is why I have
>> used setClip to "set" a clip. So, setClip() should be there as far I see.
>
>
On Tue, 9 Feb 2021 13:13:51 GMT, Jayathirth D V wrote:
>> Also, if there is no clip set, then the spec statement " If s is null, this
>> method clears the current Clip" does not carry any meaning, so in both
>> regard, setClip() should be there, I presume.
>
> @prsadhuk At first glance i also t
On Mon, 8 Feb 2021 16:53:16 GMT, Gerard Ziemski wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lanai PR#175 - 8261304 - aghaisas
>
> src/java.desktop/macosx/classes/sun/awt/CGraphicsDevice.java line 113:
>
>> 111
On Tue, 9 Feb 2021 13:59:32 GMT, Alexander Zvegintsev
wrote:
>> @prsadhuk At first glance i also thought clip() should be called after
>> calling setClip() but that is not the case.
>>
>> If we see SunGraphics2D implementation of clip() we dont exit if there is no
>> clip(usrClip object) is s
Minor upgrade from LCMS 2.11 -> 2.12
Automated tests pass, 2D demo also looks good.
-
Commit messages:
- 8260380: Upgrade to LittleCMS 2.12
Changes: https://git.openjdk.java.net/jdk/pull/2490/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2490&range=00
Issue: https:/
On Tue, 9 Feb 2021 22:52:04 GMT, Phil Race wrote:
> Minor upgrade from LCMS 2.11 -> 2.12
> Automated tests pass, 2D demo also looks good.
Marked as reviewed by jdv (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2490
On Mon, 8 Feb 2021 18:05:02 GMT, Gerard Ziemski wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lanai PR#175 - 8261304 - aghaisas
>
> src/java.desktop/macosx/classes/sun/java2d/metal/MTLRenderQueue.java line 97:
>
On Tue, 9 Feb 2021 22:52:04 GMT, Phil Race wrote:
> Minor upgrade from LCMS 2.11 -> 2.12
> Automated tests pass, 2D demo also looks good.
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2490
On Tue, 9 Feb 2021 18:10:44 GMT, Sergey Bylokhov wrote:
>>> Also, if there is no clip set, then the spec statement " If s is null, this
>>> method clears the current Clip" does not carry any meaning, so in both
>>> regard, setClip() should be there, I presume.
>>
>> The old javadoc is definite
On Wed, 10 Feb 2021 04:26:17 GMT, Prasanta Sadhukhan
wrote:
>> Looks like this is just a bug in the implementation, the null should reset
>> the clip.
>
> I am not sure if it's implementation bug. As Jim Graham has mentioned in
> thebug,
>
>> clip(null) is not legal.
>>
>> It is *setClip*(n
On Wed, 10 Feb 2021 04:47:05 GMT, Sergey Bylokhov wrote:
>> I am not sure if it's implementation bug. As Jim Graham has mentioned in
>> thebug,
>>
>>> clip(null) is not legal.
>>>
>>> It is *setClip*(null) that clears the clip.
>> I could rephrase the doc to specify NPE willbe thrrown for nul
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
> method. G2D.clip() would throw a NullPointerException when it encount
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
> method. G2D.clip() would throw a NullPointerException when it encount
On Wed, 3 Feb 2021 12:11:40 GMT, Prasanta Sadhukhan
wrote:
> Method createStrokedShape(Shape) for java.awt.BasicStroke class throws
> NullPointerException when passed a null object reference for a input
> parameter but it's not specified in the spec.
> Updated spec to illustrate this.
This pu
On Mon, 8 Feb 2021 09:30:02 GMT, Prasanta Sadhukhan
wrote:
> Constructor AreaAveragingScaleFilter(int, int) for
> java.awt.image.AreaAveragingScaleFilter class throws IllegalArgumentException
> when 0 is passed for width,height but it's not specified in the spec.
> Updated spec to illustrate t
21 matches
Mail list logo
