On Tue, 9 Feb 2021 12:29:52 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal API.
Fix a typo in Rectangle2D.add(double, double) and add(Point2D pt). It has
already been fixed in Rectangle.add(int, int)
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/Rectangle.java#L921
-
Commit messages:
- 4841153: java.awt.geom.Rectangle2D.add
On Tue, 9 Feb 2021 22:52:04 GMT, Phil Race wrote:
> Minor upgrade from LCMS 2.11 -> 2.12
> Automated tests pass, 2D demo also looks good.
This pull request has now been integrated.
Changeset: 4caeb39f
Author:Phil Race
URL: https://git.openjdk.java.net/jdk/commit/4caeb39f
Stats: 7
On Wed, 10 Feb 2021 13:10:15 GMT, Prasanta Sadhukhan
wrote:
> Fix a typo in Rectangle2D.add(double, double) and add(Point2D pt). It has
> already been fixed in Rectangle.add(int, int)
> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/Rectangle.java#L921
Mark
On Wed, 10 Feb 2021 13:10:15 GMT, Prasanta Sadhukhan
wrote:
> Fix a typo in Rectangle2D.add(double, double) and add(Point2D pt). It has
> already been fixed in Rectangle.add(int, int)
> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/Rectangle.java#L921
This
On Wed, 10 Feb 2021 04:51:33 GMT, Prasanta Sadhukhan
wrote:
>> If "*setClip*(null)" has to clear the clip then it should be specified,
>> currently, that method said nothing about the null parameter.
>
> As per code
> public void setClip(Shape sh) {
> usrClip = transformShape(sh);
>
>
On Wed, 10 Feb 2021 06:01:59 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>> me
On Wed, 10 Feb 2021 18:30:18 GMT, Phil Race wrote:
>> As per code
>> public void setClip(Shape sh) {
>> usrClip = transformShape(sh);
>>
>> usrClip is set to null if "sh" is null so clip is cleared...I will update
>> the setClip doc too..
>
> From what I can tell, if clip is null, then
On Wed, 10 Feb 2021 18:46:33 GMT, Phil Race wrote:
>> From what I can tell, if clip is null, then calling clip(null) has no effect.
>> And it won't throw an NPE in that case. So the proposed documentation is
>> less accurate than no documentation at all.
>> And I would shy away from changing the
On Mon, 8 Feb 2021 23:07:39 GMT, Gerard Ziemski wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lanai PR#175 - 8261304 - aghaisas
>
> Changes requested by gziemski (Committer).
I tried to code review the native im
On Tue, 9 Feb 2021 12:29:52 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal API.
On Wed, 10 Feb 2021 21:40:46 GMT, Gerard Ziemski wrote:
>> Changes requested by gziemski (Committer).
>
> I tried to code review the native implementation files, but Metal APIs is
> brand new to me and it's been a long while since I worked with graphics API,
> so I can't be of much help really.
On Wed, 10 Feb 2021 21:45:37 GMT, Gerard Ziemski wrote:
>> Ajit Ghaisas has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Lanai PR#177 - 8261430 - aghaisas
>> - Lanai PR#176 - 8261399 - jdv
>
> Marked as reviewed by gziemski (Committer)
On Sun, 31 Jan 2021 01:41:55 GMT, Sergey Bylokhov wrote:
> The specification of the java.awt.color.ICC_Profile.getInstance(byte[]) is
> updated.
> Its implementation changed over time, and different exceptions were thrown,
> but since JDK-8013430 always throws an IllegalArgumentException on nul
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
> method. G2D.clip() would throw a NullPointerException when it encount
> **Description :**
> This is the implementation of [JEP 382 : New macOS Rendering
> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
> It implements a Java 2D internal rendering pipeline for macOS using the Apple
> Metal API.
> The entire work on this was done under [OpenJDK Project -
> **Description :**
> This is the implementation of [JEP 382 : New macOS Rendering
> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
> It implements a Java 2D internal rendering pipeline for macOS using the Apple
> Metal API.
> The entire work on this was done under [OpenJDK Project -
On Wed, 10 Feb 2021 22:31:12 GMT, Gerard Ziemski wrote:
>> Marked as reviewed by gziemski (Committer).
>
> According to Xcode Instruments leak profile, there are 2 minor memory leaks
> in the Metal rendering pipeline:
>
> `#1 Malloc 80 Bytes 1 0x7fde0d4247b0 80 Byteslibjava.dyl
On Thu, 11 Feb 2021 05:41:15 GMT, Ajit Ghaisas wrote:
>> According to Xcode Instruments leak profile, there are 2 minor memory leaks
>> in the Metal rendering pipeline:
>>
>> `#1 Malloc 80 Bytes 1 0x7fde0d4247b0 80 Byteslibjava.dylib
>> getStringUTF8`
>>0 libsystem_malloc
On Fri, 5 Feb 2021 22:59:43 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Lanai PR#179 - 8261402 - avu
>> - Lanai PR#178 - 8261273 - avu
>
> src/java.desktop/macosx/native/libawt_lwawt/jav
20 matches
Mail list logo
