Re: [OpenJDK 2D-Dev] RFR: 8263583: Emoji rendering on macOS [v3]

2021-05-07 Thread Dmitry Batrak
On Thu, 6 May 2021 19:40:16 GMT, Phil Race wrote: >> Dmitry Batrak has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8263583: Emoji rendering on macOS >> >> add 'static' modifier to a variable > > src/java.desktop/macosx/native/libawt

Re: [OpenJDK 2D-Dev] RFR: 8263583: Emoji rendering on macOS [v3]

2021-05-07 Thread Dmitry Batrak
> This is the implementation used by JetBrains Runtime for the last 4 years, > after some cleanup, and with one problem, > found while preparing the pull request, fixed. > Even though typical scenarios for a UI application should be covered, it's > not a complete solution. In particular, emoji-s

Re: [OpenJDK 2D-Dev] RFR: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline [v2]

2021-05-07 Thread Jayathirth D V
On Wed, 5 May 2021 07:37:23 GMT, Jayathirth D V wrote: >> We have many if else conditions to select OpenGL/Metal pipeline objects. >> Apart from initialization phase we should not fetch these objects everytime >> checking whether we are using OpenGL/Metal pipeline. > > Jayathirth D V has updated

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v3]

2021-05-07 Thread Alexander Zuev
On Fri, 30 Apr 2021 20:23:21 GMT, Alexey Ivanov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp >> >> Select one icon at a time. >> >

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v3]

2021-05-07 Thread Alexander Zuev
On Fri, 30 Apr 2021 20:34:01 GMT, Alexey Ivanov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp >> >> Select one icon at a time. >> >

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v3]

2021-05-07 Thread Alexander Zuev
On Fri, 30 Apr 2021 20:54:01 GMT, Alexey Ivanov wrote: >> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line >> 1146: >> >>> 1144: } >>> 1145: Map multiResolutionIcon = new HashMap<>(); >>> 1146: int start = size > MAX_QUALITY_ICON ?

Re: [OpenJDK 2D-Dev] RFR: 8263583: Emoji rendering on macOS [v3]

2021-05-07 Thread Phil Race
On Fri, 7 May 2021 08:02:36 GMT, Dmitry Batrak wrote: >> This is the implementation used by JetBrains Runtime for the last 4 years, >> after some cleanup, and with one problem, >> found while preparing the pull request, fixed. >> Even though typical scenarios for a UI application should be cover

Re: [OpenJDK 2D-Dev] RFR: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline [v2]

2021-05-07 Thread Sergey Bylokhov
On Wed, 5 May 2021 07:34:12 GMT, Jayathirth D V wrote: >> src/java.desktop/macosx/classes/sun/java2d/opengl/CGLLayer.java line 60: >> >>> 58: return ptr; >>> 59: } >>> 60: >> >> dispose and getBounds(probably some others) seems to have the same >> implementation in both classes? >

[OpenJDK 2D-Dev] RFR: 8250658: Performance of ClipFlatOval Renderperf test is very low

2021-05-07 Thread Alexey Ushakov
Implemented indirect rendering (via stencil texture attachment) to stencil texture - Commit messages: - 8250658: Performance of ClipFlatOval Renderperf test is very low Changes: https://git.openjdk.java.net/jdk/pull/3929/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v4]

2021-05-07 Thread Alexander Zuev
On Fri, 30 Apr 2021 20:48:21 GMT, Alexey Ivanov wrote: >> Getting smaller icon is relevant in the case of the scaling. I do not think >> refactoring image caches from icons to multiresolution images will make code >> much cleaner - at the end we will have to extract images from the >> multires

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v4]

2021-05-07 Thread Alexander Zuev
> Fix updated after first round of review. Alexander Zuev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revisi

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v4]

2021-05-07 Thread Alexander Zuev
On Fri, 30 Apr 2021 20:50:53 GMT, Alexey Ivanov wrote: >> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 64: >> >>> 62: } >>> 63: >>> 64: if (icon.getIconWidth() != size) { >> >> Does it make sense to check that the icon is a multi-resolution