Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for fontmanager when no fonts are installed - RHBZ#862355,

2012-11-19 Thread Jiri Vanek
Not sure if last email was final refuse ;) - I would like to continue in fixing this. From current trialogue I guess I have several possible ways of fixing it - - Add another font-manager, which will be possible to enable via sun.font.fontmanager - add command line switch which will enable

[OpenJDK 2D-Dev] [8] request for review: 4892259 GIF ImageReader does not call passComplete in IIOReadUpdateListener

2012-11-19 Thread Vadim Pakhnushev
Hi, Please review a fix for bug 4892259: http://bugs.sun.com/view_bug.do?bug_id=4892259 http://cr.openjdk.java.net/~bae/4892259/webrev.00/ Actually GIFImageReader should not call neither passComplete, nor passStarted for non-interlaced images in the first place. So the fix is to check whether

[OpenJDK 2D-Dev] [8] request for review: 5082749: GIF stream metadata specification of aspect ratio is incorrect.

2012-11-19 Thread Vadim Pakhnushev
Hi, Please review fix for the bug 5082749: http://bugs.sun.com/view_bug.do?bug_id=5082749 http://cr.openjdk.java.net/~bae/5082749/webrev.00/ There is a typo in the documentation, there are correct values everywhere else in the code. Thanks, Vadim

Re: [OpenJDK 2D-Dev] [8] request for review: 4892259 GIF ImageReader does not call passComplete in IIOReadUpdateListener

2012-11-19 Thread Phil Race
Vadim, So I take it that you confirmed interlaced images do *not* exhibit this problem ? Its not obvious from the bug report that its only non-interlaced images that are the issue. I suppose a non-interlaced image could be considered a single pass but I can't find anywhere that we mandated