Re: [OpenJDK 2D-Dev] Please review JDK 7 backport of 8009199

2013-06-06 Thread Andrew Brygin
looks fine to me. Thanks, Andrew On 6/5/2013 10:57 PM, Jennifer Godinez wrote: Hi Phil and Andrew, Please review the 7u backport fix of 8009199: Printed text become garbage on Mac OSX File changed is identical in 8. Bug: http://bugs.sun.com/view_bug.do?bug_id=8009199 Webrev: http://cr.openj

Re: [OpenJDK 2D-Dev] Please review JDK 7 backport of 7183520

2013-06-06 Thread Andrew Brygin
Hi Jennifer, the fix looks fine to me. Thanks, Andrew On 6/5/2013 10:28 PM, Jennifer Godinez wrote: Hi Phil and Andrew, Please review the 7u backport fix of 7183520: [macosx]Unable to print out the defined page for 2D_PrintingTiger/JTablePrintPageRangesTest. There's a minor difference com

Re: [OpenJDK 2D-Dev] RFR 8015556 : Supplementary chars broken on macos x

2013-06-06 Thread Johnny Chen
Hi Phil, I ran Font2DTest and SwingSet2 with the patch, and they look good. Thanks, Johnny Chen On May 30, 2013, at 1:53 PM, Phil Race wrote: > http://cr.openjdk.java.net/~prr/8015556/ > http://bugs.sun.com/view_bug.do?bug_id=8015556 > > Supplementary chars are DOA in the OS X port since > th

Re: [OpenJDK 2D-Dev] JDK-8013810: UnixPrintServiceLookup not returning consistent values

2013-06-06 Thread Patrick Reinhart
Hi Phil, Thanks for your help. Seems, that I was a bit unlucky... My colleague Otmar Humbel managed it to get listed successful at the first time ;-) Cheers Patrick Am 06.06.13 23:50, schrieb Phil Race: On 6/6/2013 2:22 PM, Patrick Reinhart wrote: Hi Phil, I sent it in already the *2nd* t

Re: [OpenJDK 2D-Dev] JDK-8013810: UnixPrintServiceLookup not returning consistent values

2013-06-06 Thread Phil Race
On 6/6/2013 2:22 PM, Patrick Reinhart wrote: Hi Phil, I sent it in already the *2nd* time in November last year without getting any answer :-( OK. I'll see if I can find the right people to follow up on this. -phil. Am 06.06.13 23:10, schrieb Phil Race: Patrick, I had supposed you had

Re: [OpenJDK 2D-Dev] Please review JDK 7 backport of 8009199

2013-06-06 Thread Phil Race
Approved. -phil. On 6/5/2013 11:57 AM, Jennifer Godinez wrote: Hi Phil and Andrew, Please review the 7u backport fix of 8009199: Printed text become garbage on Mac OSX File changed is identical in 8. Bug: http://bugs.sun.com/view_bug.do?bug_id=8009199 Webrev: http://cr.openjdk.java.net/~jgo

Re: [OpenJDK 2D-Dev] Please review JDK 7 backport of 7183520

2013-06-06 Thread Phil Race
Looks OK. -phil. On 6/5/2013 11:28 AM, Jennifer Godinez wrote: Hi Phil and Andrew, Please review the 7u backport fix of 7183520: [macosx]Unable to print out the defined page for 2D_PrintingTiger/JTablePrintPageRangesTest. There's a minor difference compared to 8 as 7154047, a subset of 718

Re: [OpenJDK 2D-Dev] JDK-8013810: UnixPrintServiceLookup not returning consistent values

2013-06-06 Thread Phil Race
Patrick, I had supposed you had already signed the OCA but I don't see you here and the list is supposedly completely up to date : http://www.oracle.com/technetwork/community/oca-486395.html After some discussion we decided that this is sufficiently small and had been posted here already in a si

Re: [OpenJDK 2D-Dev] JDK-8013810: UnixPrintServiceLookup not returning consistent values

2013-06-06 Thread Patrick Reinhart
Hi Phil, Sounds excellent... I'm looking forward to it... Cheers Patrick Am 06.06.13 22:18, schrieb Phil Race: Hello, The fix looks fine since appears to be functionally equivalent to what I suggested in whatever was my last email. In terms of back porting I think we literally have until Tue

Re: [OpenJDK 2D-Dev] JDK-8013810: UnixPrintServiceLookup not returning consistent values

2013-06-06 Thread Phil Race
Hello, The fix looks fine since appears to be functionally equivalent to what I suggested in whatever was my last email. In terms of back porting I think we literally have until Tuesday to get it into 7u40. Jennifer : can you handle the logistics ? -phil. On 5/10/2013 6:15 AM, Patrick Reinhar

Re: [OpenJDK 2D-Dev] JDK-8013810: UnixPrintServiceLookup not returning consistent values

2013-06-06 Thread Patrick Reinhart
Hi Jennifer, Hi Phil, How big are the changes to get that to jdk7 update as well? The company I work for has a lot of customers that this fix would help. Cheers Patrick On 06/06/2013 07:35 PM, Jennifer Godinez wrote: Fix looks good. Jennifer On 06/01/2013 01:02 AM, Patrick Reinhart wrote:

Re: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform.

2013-06-06 Thread Sergey Bylokhov
HI, Jim. Can you review the updated version of the fix: http://cr.openjdk.java.net/~serb/8004859/webrev.03 I decided to implement an option, where transformed graphics (identity, translated, scaled) returns equivalent clip. For this in the transformShape() we preserve orientation of Rectangle, a

Re: [OpenJDK 2D-Dev] JDK-8013810: UnixPrintServiceLookup not returning consistent values

2013-06-06 Thread Jennifer Godinez
Fix looks good. Jennifer On 06/01/2013 01:02 AM, Patrick Reinhart wrote: Hi Phil, As I'm now back from my holidays I changed the fix according your suggestions: http://reinharts.dyndns.org/8013810/v3/webrev Can you take a look at it? I also restructured my webrev web folders for all older

[OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8013430: REGRESSION: closed/java/awt/color/ICC_Profile/LoadProfileTest/LoadProfileTest.java fails with java.io.StreamCorruptedException: invalid type code: EE since 8

2013-06-06 Thread andrew . brygin
Changeset: 616a73e97b38 Author:bae Date: 2013-06-06 13:57 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/616a73e97b38 8013430: REGRESSION: closed/java/awt/color/ICC_Profile/LoadProfileTest/LoadProfileTest.java fails with java.io.StreamCorruptedException: invalid type code: