Re: [OpenJDK 2D-Dev] request for review: JDK-8028722: XRender: Drawing strings with exactly 254 glyphs causes hangs

Hello Clemens, the fix looks fine to me. Thanks, Andrew On 11/20/2013 7:38 PM, Clemens Eisserer wrote: Hi, Please review my fix for JDK-8028722: "XRender: Drawing strings with exactly 254 glyphs causes hangs" available at http://cr.openjdk.java.net/~ceisserer/8028722/webrev.00/ A test is ava

Re: [OpenJDK 2D-Dev] [2d dev] [8] Review request for JDK-8028272 : Tidy warnings cleanup for javax.print package

Hi Joe, there seems to be several reasons: -- in some cases this just adds an extra line between items in successive construction. Remove the , and these s will stay as close to each other as regular lines in the document. Which means too close, or did mean for original author of the doc. See

Re: [OpenJDK 2D-Dev] request for review: JDK-8028722: XRender: Drawing strings with exactly 254 glyphs causes hangs

Hi, Looks good and is a simple work around. Not that it impacts us now but I think the tricky question is can we ever remove the workaround? ie how will we ever know when we are using a fixed xrender lib. I'd like to see core Xrender add a "GetVersion()" API so we can figure this stuff out a

Re: [OpenJDK 2D-Dev] [2d dev] [8] Review request for JDK-8028272 : Tidy warnings cleanup for javax.print package

Hi, Sergey. Looks like in some cases, it is possible to replace "" to the "" and close previous "" tag. And I had a question to a 2D team. Is duplication in the header of [1] intended? [1] http://download.java.net/jdk8/docs/api/javax/print/attribute/standard/Sides.html Like: SINGLE_DOCUMEN

Re: [OpenJDK 2D-Dev] [2d dev] [8] Review request for JDK-8028272 : Tidy warnings cleanup for javax.print package

Hello, I'm not an HTML expert, but it seems preferable to me to just remove an unnecessary "" tag rather than replacing it with "". Is there a reason to prefer ""? Otherwise the changes look fine. Thanks, -Joe On 11/20/2013 1:47 AM, Sergey Lugovoy wrote: Hi all, please review the fix. bug

[OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

Hi, this is the second review round for "8024854: Basic changes and files to build the class library on AIX". The previous reviews can be found at the end of this mail in the references section. I've tried to address all the comments and suggestio

[OpenJDK 2D-Dev] request for review: JDK-8028722: XRender: Drawing strings with exactly 254 glyphs causes hangs

Hi, Please review my fix for JDK-8028722: "XRender: Drawing strings with exactly 254 glyphs causes hangs" available at http://cr.openjdk.java.net/~ceisserer/8028722/webrev.00/ A test is available at: http://cr.openjdk.java.net/~ceisserer/8028722/XRenderElt254TextTest.java Problem description: Whe

Re: [OpenJDK 2D-Dev] [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

In looking through the ToolkitImage code some more it occurs to me that it was already designed (moreso in a previous life) to hold onto multiple representations of the image anyway. In a prior life in 1.0 and 1.1 it held separate ImageRepresentation objects for each size it was scaled to (via

[OpenJDK 2D-Dev] [2d dev] [8] Review request for JDK-8028272 : Tidy warnings cleanup for javax.print package

Hi all, please review the fix. bug: https://bugs.openjdk.java.net/browse/JDK-8028272 webrev : http://cr.openjdk.java.net/~yan/8028272/webrev.00/ This patch cleanup tidy warnings for generated html documentation for javax.print package, and do not affect the appearance of the documentation. The pa

[OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8025235: [javadoc] fix some errors in 2D

Changeset: 4592f0985e78 Author:yan Date: 2013-11-20 12:23 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4592f0985e78 8025235: [javadoc] fix some errors in 2D Reviewed-by: prr, yan Contributed-by: Dmitry Ginzburg ! src/share/classes/java/awt/Font.java ! src/share/classes/ja