[OpenJDK 2D-Dev] [9] Review Request: 8039774 [OGL] Image painting is broken if 'sun.java2d.accthreshold' is set to 0

2014-04-10 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 9. The bug occurs, when we try to call drawImageBg with scale and 'sun.java2d.accthreshold' is set to 0. The bug exists in the DrawImage.renderImageXform(). This method is called, when all our attempts to scale the image fails, and we create a buffered

Re: [OpenJDK 2D-Dev] PING: JDK-8017773: OpenJDK7 returns incorrect TrueType font metrics

2014-04-10 Thread Yasumasa Suenaga
Hi Phili, Thank you for replying. I don't know the details of what is on the end of the various links you provide and I can't go grabbing code from somewhere else. You can get patches as following: http://icedtea.classpath.org/bugzilla/attachment.cgi?id=873action=diff

Re: [OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

2014-04-10 Thread anton nashatyrev
Hello, could you please review a slightly update fix version (the regression test upgraded) fix: http://cr.openjdk.java.net/%7Eanashaty/8038000/webrev.01/ bug: https://bugs.openjdk.java.net/browse/JDK-8038000 Jim, thanks for your in-depth analysis, the validation indeed doesn't look

Re: [OpenJDK 2D-Dev] [9] Review Request: 8039774 [OGL] Image painting is broken if 'sun.java2d.accthreshold' is set to 0

2014-04-10 Thread Jim Graham
The fix looks good - approved. It might be worth noting in the comment that the returned image will be a single use image and so acceleration caching wouldn't help and just add overhead compared to rendering it directly from the sw surface. Or add a single-line comment on the new call to set