The benchmark spreads look much better and the code looks good, but I
worry that we are being inconsistent in whether or not we set the SKIP_
values. This function sets them back to 0 when done, but can we assume
that about all code that uses these methods?
...jim
On
Shouldn't Order2, lines 50,77 be ""?
Ditto for Order3, lines 56,108?
I don't think we ever use these methods with any other type of Vector,
but I guess I can see that the choice you made might be a more general
choice.
This concludes my review of the geom files per Phil's request. They
look
Perhaps a simpler fix would be to return an empty Curve list there since
you can't have an enclosed area with fewer than 2 edges (even if it is a
curve, the segments are already broken up into monotonically
increasing/decreasing sections so no single curve segment can double
back on itself and
No, I think Henry got it right and it should have only been intending to
treat its return value as Vector...
...jim
On 4/7/14 4:13 PM, Joe Darcy wrote:
Hi Henry,
Thanks for looking into this. FWIW, while I was working on
JDK-8039109: Fix unchecked and raw lin
Given how vectors of curves are constructed, either they are the output
of a previous operation, in which case you need enough curves/edges to
enclose an area and the count must be 0 or >=2, or they are the result
of ingesting a Shape. Looking at the code that ingests a Shape in
Area.pathToCur
Hello.
Please review an updated version of the fix.
Bugs which were found in the previous version:
- Destination vertical offset was
ignored(j2d_glPixelStorei(GL_PACK_SKIP_ROWS, dsty)) now we take it into
account using PtrAddBytes(pDst, dsty * dstInfo.scanStride)
- srcy wasn't recalculated f
