Hi, Phil.
Thank you for review.
An updated version:
http://cr.openjdk.java.net/~serb/4912693/webrev.02
CSR:
https://bugs.openjdk.java.net/browse/JDK-8199763
On 16/03/2018 08:57, Phil Race wrote:
- * are examples of typical and acceptable run time exceptions for such
cases.
+ * are the examples of typical and acceptable run time exceptions for such
+ * cases.
all changes like this make the grammar WRONG.
"the examples" means you've enumerated all of them in which
case they are no longer examples. They are the full list.
So revert all of these in javax.print.
The sound ones look fine.
-phil.
On 03/08/2018 03:20 PM, Sergey Bylokhov wrote:
Thank you for review.
An updated version:
http://cr.openjdk.java.net/~serb/4912693/webrev.01/
I also have updated the text in the "javax/print" package
On 18/01/2018 16:18, Dan Rollo wrote:
Hi Sergey,
Looks good to me. One minor grammar thought: “an example of a”.
Maybe: {@code NullPointerException} is example of typical...
Should be: {@code NullPointerException} is an example of a typical…
-Dan
On Jan 17, 2018, at 10:55 PM, Sergey Bylokhov
<sergey.bylok...@oracle.com> wrote:
Hello, Audio Guru.
Please review the fix for jdk11.
The text for behavior of null arguments is added to the package-info
files as suggested in the first step in the bug report. The text is
copied from the javax.print package:
https://docs.oracle.com/javase/9/docs/api/javax/print/package-summary.html
The CSR will be filed after the technical review.
Bug: https://bugs.openjdk.java.net/browse/JDK-4912693
Webrev can be found at:
http://cr.openjdk.java.net/~serb/4912693/webrev.00
--
Best regards, Sergey.
--
Best regards, Sergey.
