Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8201433: Fix potential crash in BufImg_SetupICM

Looks fine. On 12/04/2018 15:15, Alexey Ivanov wrote: Hi Sergey, Thank you for your review. Please take a look at the updated webrev: http://cr.openjdk.java.net/~aivanov/8201433/jdk11/webrev.01/ On 12/04/2018 22:33, Sergey Bylokhov wrote: Hi, Alexey. Since the test requires 1g of memory,

Re: [OpenJDK 2D-Dev] RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

On 04/13/2018 12:44 PM, Volker Simonis wrote: Phil Race > schrieb am Fr. 13. Apr. 2018 um 19:21: I suppose this potentially helps the concurrency of the build ? I can't think of why this would be a problem now there is no

Re: [OpenJDK 2D-Dev] RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

On 2018-04-13 12:44, Volker Simonis wrote: Phil Race > schrieb am Fr. 13. Apr. 2018 um 19:21: I suppose this potentially helps the concurrency of the build ? I can't think of why this would be a problem now there is no

Re: [OpenJDK 2D-Dev] RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

Phil Race schrieb am Fr. 13. Apr. 2018 um 19:21: > > I suppose this potentially helps the concurrency of the build ? > I can't think of why this would be a problem now there is no > compile-time linking > involved and it seems Linux was already fine without this, > but a

Re: [OpenJDK 2D-Dev] RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

Yes, we don't want unneeded dependencies declared as it both potentially slows down the build (though this removal will not have any measurable impact) as well as confuses humans trying to make sense of the makefiles. This removal should be fine as we don't link to libawt_xawt on any platform

Re: [OpenJDK 2D-Dev] RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

I suppose this potentially helps the concurrency of the build ? I can't think of why this would be a problem now there is no compile-time linking involved and it seems Linux was already fine without this, but a jdk-submit would be prudent .. -phil. On 04/13/2018 09:22 AM, Volker Simonis

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

Hi Phil, Thanks for your inputs. I have modified the test case to use ByteArrayOutput/InputStream. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/6574555/webrev.01/ Regards, Jay From: Phil Race Sent: Wednesday, April 11, 2018 10:40 PM To: Jayathirth D

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

Hi Phil, Thanks for your inputs. I have updated the code to reflect the changes mentioned by you and changed test case to use ByteArrayInput/OutputStream. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/6788458/webrev.08/ Regards, Jay -Original Message- From: