[OpenJDK 2D-Dev] [12] RFR JDK-8213051:Invalid use of HTML5 in javax.print files
Hi All, Please review a doc-fix to comply with HTML5 standard by removing the obsolete attribute "align" Bug: https://bugs.openjdk.java.net/browse/JDK-8213051 webrev: http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.0/ Regards Prasanta
Re: [OpenJDK 2D-Dev] [12] RFR JDK-8139178: Wrong fontMetrics when printing in Landscape
Hello Phil, > On Nov 30, 2018, at 6:27 AM, Philip Race wrote: > > Hi, > > I'd like to get this one in before 12 forks .. very soon .. are you going to > be able to get this in ? yes, I had updated the fix according to your comments, and, with your permission, I am ready to push it into the client repo: http://cr.openjdk.java.net/~bae/8139178/webrev.01/ Or do I have to use jdk-submit instead? I had posted the updated change some time ago, but there was no response… Thanks, Andrew > > -phil. > > On 11/16/18, 1:10 PM, Phil Race wrote: >> Looks good to me. Just some nits. >> >> Can we split the long lines like this ? :- >> >> #define contextAwareMetricsX(vx, vy) \ >>(FTFixedToFloat(context->transform.xx) * (vx) - \ >> FTFixedToFloat(context->transform.xy) * (vy)) >> >> and why "vx" and "vy", not just x and y ? >> >> -phil. >> >> On 11/10/18 8:53 AM, Andrew Brygin wrote: >>> Hello, >>> >>> could you please review a fix for JDK-8139178. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8139178 >>> Webrev: http://cr.openjdk.java.net/~bae/8139178/webrev.00/ >>> >>> The freetype scaler calculates font metrics with a transform >>> applied to the scaler context. We have to revert this transform >>> in order to get correct font metrics. >>> >>> Thanks, >>> Andrew >>
Re: [OpenJDK 2D-Dev] [12] RFR JDK-8139178: Wrong fontMetrics when printing in Landscape
Hi, I'd like to get this one in before 12 forks .. very soon .. are you going to be able to get this in ? -phil. On 11/16/18, 1:10 PM, Phil Race wrote: Looks good to me. Just some nits. Can we split the long lines like this ? :- #define contextAwareMetricsX(vx, vy) \ (FTFixedToFloat(context->transform.xx) * (vx) - \ FTFixedToFloat(context->transform.xy) * (vy)) and why "vx" and "vy", not just x and y ? -phil. On 11/10/18 8:53 AM, Andrew Brygin wrote: Hello, could you please review a fix for JDK-8139178. Bug: https://bugs.openjdk.java.net/browse/JDK-8139178 Webrev: http://cr.openjdk.java.net/~bae/8139178/webrev.00/ The freetype scaler calculates font metrics with a transform applied to the scaler context. We have to revert this transform in order to get correct font metrics. Thanks, Andrew
Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond
Looks fine. On 29/11/2018 01:29, Jayathirth D V wrote: Hi Sergey, Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8212875/webrev.02/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, November 27, 2018 1:29 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond On 21/11/2018 23:00, Jayathirth D V wrote: I was following ZLib like content in the table, but as you mentioned we can keep at least text mentioning that we need to look up stuff related to TIFF Technical Note #2. Also I have refined comment in BaselineTIFFTagSet. The text about zlib broke the table as well(looks like it was caused y JDK-8189702), please fix it as well. -- Best regards, Sergey.
Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond
Hi Sergey, Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8212875/webrev.02/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, November 27, 2018 1:29 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond On 21/11/2018 23:00, Jayathirth D V wrote: > I was following ZLib like content in the table, but as you mentioned we can > keep at least text mentioning that we need to look up stuff related to TIFF > Technical Note #2. Also I have refined comment in BaselineTIFFTagSet. The text about zlib broke the table as well(looks like it was caused y JDK-8189702), please fix it as well. -- Best regards, Sergey.
