Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

In that case just delete the comments and the commented out code ... -phil. On 7/12/19, 3:12 PM, Brian Burkhalter wrote: I think I'd be more inclined to make the code at 970 like that at 1036. Can’t do this exactly as drawImageBGR at 903 does not throw a PrinterException. Have to use

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

> I think I'd be more inclined to make the code at 970 like that at 1036. Can’t do this exactly as drawImageBGR at 903 does not throw a PrinterException. Have to use RuntimeException. Brian > On Jul 12, 2019, at 1:39 PM, Phil Race wrote: > > oh well ... in which I suppose this is the best

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

oh well ... in which I suppose this is the best you can do here. -phil. On 7/12/19 1:10 PM, Brian Burkhalter wrote: (2) I don't know why at 1034 you changed from PrinterIOException to PrinterException. There is no PrinterIOException constructor which accepts a String as its only parameter

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

> On Jul 12, 2019, at 1:02 PM, Phil Race wrote: > >> Not my call, but in PSPrinterJob.java (970-977) it might be cleaner to just >> delete the unused code and comment. > > Dilemma - since at 1036 we are throwing an Exception and the comment at > 970-ish suggests > the author was intending

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

Not my call, but in PSPrinterJob.java (970-977) it might be cleaner to just delete the unused code and comment. Dilemma - since at 1036 we are throwing an Exception and the comment at 970-ish suggests the author was intending to do what s/he did at 1036 but never got around to it. I think

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

Here is new webrev incorporating the two changes below. http://cr.openjdk.java.net/~bpb/8187898/webrev.01/ Thanks, Brian > On Jul 12, 2019, at 12:01 PM, Brian Burkhalter > wrote: > >> On Jul 12, 2019, at 11:17 AM, Roger Riggs > > wrote: >> >> Would it be

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

Hi Roger, > On Jul 12, 2019, at 11:17 AM, Roger Riggs wrote: > > Would it be appropriate to add @Override to the new method (and perhaps > existing overridden methods). Yes, I think so. > Previously, calling FilterOutputStream.write(byte[]) would delegate to > write(byte[], 0, length). >

Re: [OpenJDK 2D-Dev] [14] Review request for 8227392: Colors with alpha are painted incorrectly on Linux, after JDK-8214579

> Would such a workaround be acceptable as part of this back out fix? Yes, very much so ! -phil. On 7/12/19 11:34 AM, Anton Litvinov wrote: Hello Phil, I tried to apply your code and can confirm that value of "color" is always the same for the case, when the test passes and fails. For each

Re: [OpenJDK 2D-Dev] [14] Review request for 8227392: Colors with alpha are painted incorrectly on Linux, after JDK-8214579

Hello Phil, I tried to apply your code and can confirm that value of "color" is always the same for the case, when the test passes and fails. For each test run the "paint(Graphics)" method is called either 2 or 3 times and this tracing output is always the same and following:

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

Hi Brian, Would it be appropriate to add @Override to the new method (and perhaps existing overridden methods). Previously, calling FilterOutputStream.write(byte[]) would delegate to write(byte[], 0, length). The proposed change duplicates the code and changes the ways that overridden

Re: [OpenJDK 2D-Dev] RFR: 8227587: Add internal privileged System.loadLibrary

Just to recap what we discussed offline: We could introduce BootLoader::loadLibrary to load a system native library for boot loader.  sys_path and systemNativeLibraries in ClassLoader implementation are solely for boot loader and it seems cleaner for BootLoader to handle loading of system native

Re: [OpenJDK 2D-Dev] RFR: 8227587: Add internal privileged System.loadLibrary

Claes, Thanks for exploring this.  I would like to see if we can avoid introducing an internal @CS method (keep @CSM only for public APIs will help security analysis). There are other alternatives to improve the footprint performance. One idea is java.base and java.desktop each has its own

Re: [OpenJDK 2D-Dev] RFR: 8227587: Add internal privileged System.loadLibrary

Hi, Regarding all the touches on the desktop module 1) awt-dev isn't the only list, you should have included swing-dev and 2d-dev at least 2) I am wondering what client testing you propose to do to verify this ? 3) I've spent spare time over a number of months trying to decrease unnecessary