Hi Prahalad,
The changes look fine to me.
Thanks,
Krishna
-Original Message-
From: Prahalad Kumar Narayanan
Sent: Friday, March 23, 2018 1:40 PM
To: 2d-dev <2d-dev@openjdk.java.net>
Subject: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]:
JPGWriter.getNumThumbnailsSupported does not return -
Hi Jay,
I have some points as below:
1. I suggest to rename considerTransparentPixel as isAlphaPresent.
2. You can refactor the function body as below:
Return ((destinationBands == null ||
destinationBands.length == 4) &&
metadata.tRNS_colorType =
18 1:43 PM
To: Krishna Addepalli ; 2d-dev
<2d-dev@openjdk.java.net>
Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS
chunk while reading non-indexed RGB images
Hi Krishna,
Thanks for providing the inputs.
1. I suggest to rename considerTra
y, April 2, 2018 11:33 AM
To: Krishna Addepalli ; 2d-dev
<2d-dev@openjdk.java.net>
Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS
chunk while reading non-indexed RGB images
Hi Krishna,
The constant values for different color types is :
static final in
Hi Jay,
Here are my observations/questions:
1. I see that the fix is to update the bKGD_colorType for Background
color child. However, don't you need to do the same thing for paletted images
as well?
2. As for the test case, I'm not sure how ImageReaders and ImageWriters
work.
Hi Phil,
The changes look fine to me. However I have one question: In
SOFMarkerSegment.java file, in the function below,
int getIDencodedCSType () {
for (int i = 0; i < componentSpecs.length; i++) {
if (componentSpecs[i].componentId < 'A') {
return JPEG.JCS_UNKNOWN;
Looks fine
-Original Message-
From: Phil Race
Sent: Monday, July 2, 2018 10:46 PM
To: Sergey Bylokhov ; awt-...@openjdk.java.net;
2d-dev <2d-dev@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] [11] Review Request: 8201611 Broken
links in java.desktop javadoc
OK, +1
-phil.
On 07/02/
+1
-Krishna
-Original Message-
From: Philip Race
Sent: Saturday, July 28, 2018 11:38 PM
To: 2d-dev <2d-dev@openjdk.java.net>
Subject: [OpenJDK 2D-Dev] RFR: 8208466: Fix potential memory leak in harfbuzz
shaping
bug: https://bugs.openjdk.java.net/browse/JDK-8208466
webrev: http://cr.open
Dear Ralph,
Thanks for pointing this out, could you also come up with a patch for the same?
Thanks,
Krishna
-Original Message-
From: Ralph Hummeling
Sent: Friday, July 20, 2018 8:25 PM
To: 2d-dev@openjdk.java.net
Cc: james.gra...@oracle.com
Subject: [OpenJDK 2D-Dev] ArcIterator#btan(do
Hummeling
Sent: Tuesday, August 14, 2018 7:59 PM
To: Krishna Addepalli ; 2d-dev@openjdk.java.net
Cc: james.gra...@oracle.com
Subject: Re: [OpenJDK 2D-Dev] ArcIterator#btan(double)
Dear Krishna,
I'd love to. How do I best do that?
Kind regards,
Ralph Hummeling
+316 5758 1679
Humm
Sorry, I replied assuming certain things before actually clarifying.
Are you asking about the process for submitting a patch? Could you be a bit
more specific so that I can answer better?
-Original Message-
From: Krishna Addepalli
Sent: Tuesday, August 14, 2018 8:04 PM
To: Ralph
Looks good to me!
Thanks
Krishna
> On 09-Sep-2018, at 1:21 AM, Philip Race wrote:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8210384
> webrev: http://cr.openjdk.java.net/~prr/8210384/
>
> AAT is the Apple alternative to OpenType layout.
>
> Calls to the Harfbuzz layout engine need to p
Looks fine!
> On 20-Sep-2018, at 8:52 AM, Phil Race wrote:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8209548
> webrev: http://cr.openjdk.java.net/~prr/8209548/
>
> Clean up of some pointless and incorrect code in freetypescaler.c
>
> -phil
/unix/native/common/awt/awt_Font.c.udiff.html
>>>
>>> <http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/src/java.desktop/unix/native/common/awt/awt_Font.c.udiff.html>
>>>
>>> why would that not be #ifdef instead ?
>>>
>>>
Hi Kim,
An alternative way to fix it would be to declare the loop variable itself as
unsigned, since the channels can never be negative, but that would require you
to cast to int in two places.
Also, when casting, it is better to use static_cast, rather than C
style casting.
Thanks,
Krishna
-
Hi Sergey,
I found a few places where @code tag should be added in ICC_Profile.java: 1570,
1601, 1894, 1895, 1902, 1904.
Thanks,
Krishna
> On 23-Oct-2018, at 4:50 AM, Sergey Bylokhov
> wrote:
>
> Hello.
> Please review a javadoc "weekend cleanup" in jdk 12.
>
> Bug: https://bugs.openjdk.jav
+1
Krishna
> On 25-Oct-2018, at 10:06 AM, Sergey Bylokhov
> wrote:
>
> Hi, Krishna.
> Thank you for review!
>
>> 1894, 1895, 1902, 1904.
> The text on the lines above is a block comment not a javadoc, the tags are
> not necessary there.
>
>> 1570, 1601,
>
> I have fixed these:
> http://cr
+1
Thanks,
Krishna
-Original Message-
From: Jayathirth D V
Sent: Tuesday, November 20, 2018 1:59 PM
To: 2d-dev <2d-dev@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795:
ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458
Thanks Sergey for the review.
Hi Jay,
While the exception is suppressed with your fix, I think it makes sense to add
some logging of this fact, so that it could aid in debugging.
Thanks,
Krishna
-Original Message-
From: Jayathirth D V
Sent: Friday, November 16, 2018 12:30 PM
To: 2d-dev@openjdk.java.net
Subject: Re:
Thanks for the clarification Jay.
The changes look fine.
Krishna
-Original Message-
From: Jayathirth D V
Sent: Tuesday, November 20, 2018 3:37 PM
To: Krishna Addepalli ; 2d-dev@openjdk.java.net
Subject: RE: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt
CRC for IEND
K3 and did not find any crashes.
Thanks,
Krishna
From: Krishna Addepalli
Sent: Tuesday, October 2, 2018 8:53 PM
To: Philip Race
Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>; build-dev
Subject: Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]: Resolve
disabled warnings
Hi Magnus,
Thanks for taking a look. I was wanting to change the SAFE_ALLOC definition,
but since that file is in java.base, I was not sure of changing it.
Krishna
From: Magnus Ihse Bursie
Sent: Tuesday, November 27, 2018 6:52 PM
To: Krishna Addepalli
Cc: Philip Race ; awt
Looks good to me.
Krishna
> On 01-Dec-2018, at 7:33 AM, Sergey Bylokhov
> wrote:
>
> Hello.
> Please review the fix for jdk 12.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214461
> Webrev: http://cr.openjdk.java.net/~serb/8214461/webrev.00
>
> We have a few internal classes/interfaces
23 matches
Mail list logo
