[OpenJDK 2D-Dev] Review Request for bug (JDK-8039345) Strange behaviour of per-pixel translucency on linux

Hi, Please review a fix for this issue: 8039345 Strange behaviour of per-pixel translucency on linux Bug description: https://bugs.openjdk.java.net/browse/JDK-8039345 webrev: http://cr.openjdk.java.net/~serb/prasanta/8039345/webrev.00/ Note: A wrong (PictStandardRGB24) picture format was used

Re: [OpenJDK 2D-Dev] Review Request for bug (JDK-8039345) Strange behaviour of per-pixel translucency on linux

] http://docs.oracle.com/javase/tutorial/uiswing/concurrency/dispatch.html Thanks, Alexander. On 02/17/2015 03:43 PM, prasanta sadhukhan wrote: A reg. testcase is added to the webrev http://cr.openjdk.java.net/~serb/prasanta/8039345/webrev.01/ Regarding the transparency parameter, I decided

[OpenJDK 2D-Dev] Review Request: (JDK-8048782) OpenJDK: PiscesCache : xmax/ymax rounding up can cause RasterFormatException.

Hi, I would like a review for a solution of this bug. In OpenJDK9, java.awt.image.RasterFormatException: (x + width) is outside raster is thrown when the bounding box width outgrows original raster. This is because PiscesRenderingEngine does not take care of clipping the bounding box

Re: [OpenJDK 2D-Dev] Review Request: (JDK-8077584) Value of java.awt.font.OpenType.TAG_OPBD is incorrect

Hi Sergey, Done. http://cr.openjdk.java.net/~psadhukhan/8077584/webrev.01/ Regards Prasanta On 4/30/2015 5:02 PM, Sergey Bylokhov wrote: Hi, Prasanta. Can you split the long lines in the test? On 30.04.15 9:03, prasanta sadhukhan wrote: Hi All, Any feedback? Can this be committed? Regards

[OpenJDK 2D-Dev] RFR: (JDK-8015368) [TESTBUG] javax/print/attribute/URLPDFPrinting.java fails on solaris with java.net.ConnectException: Connection timed out

Hi, The test in question was trying to connect to an address that when run inside Oracle needs an HTTP proxy and the test system is not configured with proxies so it's getting timed out. The fix is to generate a simple pdf and use it from local folder. Also, moved the test out of closed repo

Re: [OpenJDK 2D-Dev] Review Request: (JDK-8077584) Value of java.awt.font.OpenType.TAG_OPBD is incorrect

Hi All, Any feedback? Can this be committed? Regards Prasanta On 4/15/2015 5:07 PM, prasanta sadhukhan wrote: Hi, I would like a review for a jdk9 fix whereby TAG_OPBD tag is updated to correct value. Bug: https://bugs.openjdk.java.net/browse/JDK-8077584 webrev: http://cr.openjdk.java.net

Re: [OpenJDK 2D-Dev] RFR: (JDK-8015368) [TESTBUG] javax/print/attribute/URLPDFPrinting.java fails on solaris with java.net.ConnectException: Connection timed out

Hi All, Any feedback? Can this be committed? Regards Prasanta On 5/5/2015 11:18 AM, prasanta sadhukhan wrote: Thanks Phil for pointing that. I have added the GPL. Please find the modified webrev http://cr.openjdk.java.net/~psadhukhan/8015368/webrev.00/ Regards Prasanta On 5/4/2015 9:53 PM

Re: [OpenJDK 2D-Dev] Review Request: (JDK-8077584) Value of java.awt.font.OpenType.TAG_OPBD is incorrect

Hi All, Any more feedback? Can this be committed? Regards Prasanta On 5/5/2015 11:31 AM, prasanta sadhukhan wrote: Thanks for the info. It's Done. http://cr.openjdk.java.net/~psadhukhan/8077584/webrev.02/ Regards Prasanta On 5/4/2015 9:54 PM, Phil Race wrote: Please remove the @author tag

Re: [OpenJDK 2D-Dev] Review Request: (JDK-8077584) Value of java.awt.font.OpenType.TAG_OPBD is incorrect

Thanks for the info. It's Done. http://cr.openjdk.java.net/~psadhukhan/8077584/webrev.02/ Regards Prasanta On 5/4/2015 9:54 PM, Phil Race wrote: Please remove the @author tag. We do not use them in OpenJDK -phil. On 04/30/2015 05:00 AM, prasanta sadhukhan wrote: Hi Sergey, Done. http

Re: [OpenJDK 2D-Dev] RFR: (JDK-8015368) [TESTBUG] javax/print/attribute/URLPDFPrinting.java fails on solaris with java.net.ConnectException: Connection timed out

path exception -phil. On 05/04/2015 01:17 AM, prasanta sadhukhan wrote: Hi, The test in question was trying to connect to an address that when run inside Oracle needs an HTTP proxy and the test system is not configured with proxies so it's getting timed out. The fix is to generate a simple

[OpenJDK 2D-Dev] RFR: (JDK-7011935) Using AWT in fullscreen exclusive mode results in a black screen

Hi, Please review a fix for fullscreen mode not working in D3D pipeline. It seems D3DPRESENT_PARAMETERS Windowed flag needs to be enabled for fullscreen mode to be in effect. https://bugs.openjdk.java.net/browse/JDK-7011935 http://cr.openjdk.java.net/~psadhukhan/7011935/webrev.00/ Regards

Re: [OpenJDK 2D-Dev] RFR: (JDK-8015368) [TESTBUG] javax/print/attribute/URLPDFPrinting.java fails on solaris with java.net.ConnectException: Connection timed out

Gentle reminder. If there is no more issue, can this webrev be commited? Regards Prasanta On 5/11/2015 11:25 AM, prasanta sadhukhan wrote: Hi All, Any feedback? Can this be committed? Regards Prasanta On 5/5/2015 11:18 AM, prasanta sadhukhan wrote: Thanks Phil for pointing that. I have

[OpenJDK 2D-Dev] Review Request: (JDK-8044788) [D3D] clip is ignored during surface-sw blit

Hi, I would like a review for a solution of this bug in jdk9. The clip was ignored during surface-sw blit in d3d pipeline. The fix is to use the clip parameter to calculate the blit coordinates correctly. Bug: https://bugs.openjdk.java.net/browse/JDK-8044788 webrev:

[OpenJDK 2D-Dev] Review Request: (JDK-8077584) Value of java.awt.font.OpenType.TAG_OPBD is incorrect

Hi, I would like a review for a jdk9 fix whereby TAG_OPBD tag is updated to correct value. Bug: https://bugs.openjdk.java.net/browse/JDK-8077584 webrev: http://cr.openjdk.java.net/~psadhukhan/8077584/webrev.00/ Regards Prasanta

Re: [OpenJDK 2D-Dev] Review Request for bug (JDK-8080287): The image of BufferedImage.TYPE_INT_ARGB and BufferedImage.TYPE_INT_ARGB_PRE is blank

. Thanks, Andrew On 6/22/2015 12:36 PM, prasanta sadhukhan wrote: Hi , Please review a fix for this issue: It was found that RescaleOp on image with different alpha cannot render the image as there is a particular flaw in RescaleOp implementation whereby the source alpha channel is never

Re: [OpenJDK 2D-Dev] Review Request for bug (JDK-8080287): The image of BufferedImage.TYPE_INT_ARGB and BufferedImage.TYPE_INT_ARGB_PRE is blank

created a manual test. Probably an automated test is a bit more convenient option here. Also, there seems to be no need for a jpg image for this test. A source image with color strips is much more useful. Thanks, Andrew On 6/22/2015 12:36 PM, prasanta sadhukhan wrote: Hi , Please

[OpenJDK 2D-Dev] RFR [TestBug 8080086]: Test javax/imageio/plugins/png/ItxtUtf8Test.java fails on Linux with G1 GC

Hi All, The test throws OOME in 64bit linux but passes in 32bit linux. It seems to require more memory for 64bit system so increasing the max heap size from 2MB to 4MB to execute the test successfully on 64bit linux. bug: https://bugs.openjdk.java.net/browse/JDK-8080086 webrev:

Re: [OpenJDK 2D-Dev] RFR [TestBug 8080086]: Test javax/imageio/plugins/png/ItxtUtf8Test.java fails on Linux with G1 GC

? On 25.05.15 14:16, prasanta sadhukhan wrote: Hi All, The test throws OOME in 64bit linux but passes in 32bit linux. It seems to require more memory for 64bit system so increasing the max heap size from 2MB to 4MB to execute the test successfully on 64bit linux. bug: https://bugs.openjdk.java.net

Re: [OpenJDK 2D-Dev] Review Request for bug (JDK-8080287): The image of BufferedImage.TYPE_INT_ARGB and BufferedImage.TYPE_INT_ARGB_PRE is blank

existed for the raster case... ...jim On 6/23/15 11:30 PM, prasanta sadhukhan wrote: Hi Jim,All I have modified the code following your comments. Please find the modified webrev: http://cr.openjdk.java.net/~psadhukhan/8080287/webrev.02/ Could you please review this? Regards Prasanta

Re: [OpenJDK 2D-Dev] Review Request JDK-8129457: Disposer.pollRemove may fail to dispose

Gentle reminder for review of this small fix. Regards Prasanta On 6/24/2015 2:34 PM, prasanta sadhukhan wrote: Hi, Please review a small fix for this issue where it seems if polling is performed before the bounds are checked then it may happen that obj maybe removed from queue without

Re: [OpenJDK 2D-Dev] Review Request for bug (JDK-8080287): The image of BufferedImage.TYPE_INT_ARGB and BufferedImage.TYPE_INT_ARGB_PRE is blank

discover that it would be easy to have ImagingLib take a list of subset bands which might help us avoid doing all of the createChildRaster calls in filter(Bimg)... ...jim On 6/28/2015 11:44 PM, prasanta sadhukhan wrote: Hi Jim, I was following the RescaleOp spec where it states

Re: [OpenJDK 2D-Dev] RFR: [JDK-8130400] Test java/awt/image/DrawImage/IncorrectClipXorModeSurface2Surface.java fails with ClassCastException

Hi Clemens, All, Is this good to commit? Regards Prasanta On 7/28/2015 12:46 AM, prasanta sadhukhan wrote: Thanks Phil for the review. Modified webrev can be found here: http://cr.openjdk.java.net/~psadhukhan/8130400/webrev.01/ Please let me know if this ok. Regards Prasanta On 7/25/2015 4

Re: [OpenJDK 2D-Dev] Review Request for bug (JDK-8080287): The image of BufferedImage.TYPE_INT_ARGB and BufferedImage.TYPE_INT_ARGB_PRE is blank

= new BufferedImage(w, h, BufferedImage.TYPE_INT_ARGB); bimg1 = res.filter(bimg, bimg1); -phil. On 07/31/2015 05:32 PM, prasanta sadhukhan wrote: Hi Jim, Thanks for your comments. In fact, Phil and I was discussing the same thing. I have modified the same. Please find the modified webrev: http

Re: [OpenJDK 2D-Dev] Review Request for bug (JDK-8080287): The image of BufferedImage.TYPE_INT_ARGB and BufferedImage.TYPE_INT_ARGB_PRE is blank

to display a result to ask a user to verify something we can do by examining the pixel values in the result... Modified webrev with automated test is below: http://cr.openjdk.java.net/~psadhukhan/8080287/webrev.04/ Regards Prasanta ...jim On 7/29/15 11:21 AM, prasanta sadhukhan wrote: Hi Jim, Thanks

Re: [OpenJDK 2D-Dev] RFR: [JDK-8130400] Test java/awt/image/DrawImage/IncorrectClipXorModeSurface2Surface.java fails with ClassCastException

? -phil. On 07/22/2015 12:08 AM, prasanta sadhukhan wrote: Hi All, It seems OGL and D3D pipeline delegates XORcomposite transform to DrawImage#renderImageXform which is the solution opted for XRender pipeline too. Can you please review this? Regards Prasanta On 7/17/2015 5:10 PM, prasanta

[OpenJDK 2D-Dev] RFR: [JDK-8130400] Test java/awt/image/DrawImage/IncorrectClipXorModeSurface2Surface.java fails with ClassCastException

Hi, Bug: https://bugs.openjdk.java.net/browse/JDK-8130400 webrev: http://cr.openjdk.java.net/~psadhukhan/8130400/webrev.00/ The test fails with ClassCastException java.lang.ClassCastException: sun.java2d.loops.XORComposite cannot be cast to java.awt.AlphaComposite when drawing volatimeImage

[OpenJDK 2D-Dev] [9]: RFR JDK-8139803, , Fix for 8132985 breaks OpenJDK build on windows

Hi All, Please review a small fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-8139803 webrev: http://cr.openjdk.java.net/~psadhukhan/8139803/webrev/ Fix for 8132985: Crash in freetypescaler.c due to double free was breaking openjdk build on windows as an used variable was not

Re: [OpenJDK 2D-Dev] [9] RFR JDK-7161283: [macosx]filedialog didn't pop up for awt test InvalidParametersNativeTest

Gentle reminder for review On 10/13/2015 5:18 PM, prasanta sadhukhan wrote: Gentle reminder for review. Regards Prasanta On 10/9/2015 12:34 PM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-7161283 webrev: http

[OpenJDK 2D-Dev] [9] RFR: JDK-7077412, , [TEST_BUG]closed/java/awt/print/PrinterJob/PaintText.java failed (timeout error)

Hi All, Please review a small fix in the test program. Bug: https://bugs.openjdk.java.net/browse/JDK-7077412 webrev: http://cr.openjdk.java.net/~psadhukhan/7077412/webrev.00/ PaintText.java checks for test.java system property and if not found then it opens up a printer dialog and waits for

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-7077412, , [TEST_BUG]closed/java/awt/print/PrinterJob/PaintText.java failed (timeout error)

It seems jtreg uses test.jdk and not test.java so modified test program to check for test.jdk to differentiate between jtreg and non-jtreg execution Modified webrev http://cr.openjdk.java.net/~psadhukhan/7077412/webrev.01 Regards Prasanta On 10/26/2015 3:10 PM, prasanta sadhukhan wrote: Hi All

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8139216: Non-ASCII characters in CUPS printer names are not properly displayed

:16 PM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 where it was found that non-ASCII characters in CUPS printer name are not properly displayed. Bug: https://bugs.openjdk.java.net/browse/JDK-8139216 webrev: http://cr.openjdk.java.net/~psadhukhan/8139216/webrev.00

[OpenJDK 2D-Dev] [9] RFR: JDK-8020448: Test closed/java/awt/font/JNICheck/JNICheck.sh fails on Solaris 11

Hi All, Please review a small fix in jdk9 whereby JNICheck issued a warning that Exception is not checked after calling a JNI method. This is in continuation to JDK-8130507 fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8020448 webrev:

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8067059, , PrinterJob.pageDialog() with DialogSelectionType.NATIVE returns a PageFormat when cancelled.

does a number of wild card imports instead of the specific classes it needs. And I am not sure why it is importing java.awt.* anyway .. And I find qualifying "java.lang.String" to be unnecessary. will update the test. Regards Prasanta -phil. On 11/3/15, 12:59 AM, prasanta sadhukhan wrot

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8067059, , PrinterJob.pageDialog() with DialogSelectionType.NATIVE returns a PageFormat when cancelled.

, prasanta sadhukhan wrote: Hi Phil, On 11/13/2015 12:05 AM, Philip Race wrote: Shouldn't this use reference equality ? It seems Object.java equals() method does == anyways and it seems it always better to call equals() than to explicitly check for == Is it not correct? If it is not, I will change

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-8023213 [macosx] closed/java/awt/FontClass/NaNTransform.java fails on MacOS X 10.9

in this so as not to leave it to chance ? -phil. On 11/05/2015 11:49 PM, prasanta sadhukhan wrote: Hi Phil, On 11/5/2015 4:54 AM, Philip Race wrote: This does not look right to me. Who knows what data is on the canvas ? it is not clear that it is 'blank'. It could have data from a previous glyph

Re: [OpenJDK 2D-Dev] Review request for JDK-6967419 : IndexOutOfBoundsException when drawing PNGs

/ <http://cr.openjdk.java.net/%7Erchamyal/jay/6967419/webrev.01/> Thanks, Jay *From:*prasanta sadhukhan *Sent:* Friday, November 06, 2015 2:45 PM *To:* Jayathirth D V; 2d-dev@openjdk.java.net *Cc:* Philip Race *Subject:* Re: Review request for JDK-6967419 : IndexOutOfBoundsException when d

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8139216: Non-ASCII characters in CUPS printer names are not properly displayed

Hi Phil, On 10/30/2015 12:33 AM, Phil Race wrote: On 10/25/2015 11:56 PM, prasanta sadhukhan wrote: Hi All, I have modified the fix to assign printer name in case UnsupportedEncodingException is thrown which is unlikely as we are using UTF-8 as character encoding and not any user-supplied

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8139216: Non-ASCII characters in CUPS printer names are not properly displayed

@Rajeev, could you please review and approve it? Regards Prasanta On 11/2/2015 11:03 AM, prasanta sadhukhan wrote: Thanks Phil. I need +1 for this. @Sergey, could you please review and approve it? Regards Prasanta On 10/30/2015 11:39 PM, Phil Race wrote: Ok .. approved. -phil. On 10/29/2015

[OpenJDK 2D-Dev] [9] RFR JDK-8067059, , PrinterJob.pageDialog() with DialogSelectionType.NATIVE returns a PageFormat when cancelled.

Hi All, Please review a fix for jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-8067059 webrev: http://cr.openjdk.java.net/~psadhukhan/8067059/webrev.00/ The issue was if we "cancel" Printer Job setup dialog which has been created with DialogSelectionType.NATIVE it should return "null"

Re: [OpenJDK 2D-Dev] [9] RFR JDK-7161283: [macosx]filedialog didn't pop up for awt test InvalidParametersNativeTest

@Rajeev, Phil...please review. Regards Prasanta On 10/26/2015 3:58 PM, prasanta sadhukhan wrote: Gentle reminder for review On 10/13/2015 5:18 PM, prasanta sadhukhan wrote: Gentle reminder for review. Regards Prasanta On 10/9/2015 12:34 PM, prasanta sadhukhan wrote: Hi All, Please review

[OpenJDK 2D-Dev] [9] RFR: JDK-8039412, , Stack overflow on Linux using DialogTypeSelection.NATIVE

Hi All, Please review a fix for jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-8039412 webrev: http://cr.openjdk.java.net/~psadhukhan/8039412/webrev.00/ Issue was seen in linux whereby if we call PrinterJob.pageDialog() after PrinterJob.printDialog() it results in StackOverflowError if

Re: [OpenJDK 2D-Dev] Review request for JDK-6967419 : IndexOutOfBoundsException when drawing PNGs

Hi Jay, looks ok but I guess you need to do the same for finish() method too in similar way you did for finishChunk() as finish() is called from write_IHDR, write_CHRM etc and it calls flushBefore(). Also, I guess you should not consume IOB Exception and let it be thrown to user instead of

[OpenJDK 2D-Dev] [9] RFR: JDK-8139216: Non-ASCII characters in CUPS printer names are not properly displayed

Hi All, Please review a fix for jdk9 where it was found that non-ASCII characters in CUPS printer name are not properly displayed. Bug: https://bugs.openjdk.java.net/browse/JDK-8139216 webrev: http://cr.openjdk.java.net/~psadhukhan/8139216/webrev.00/ It was found that the printer "äbc"

[OpenJDK 2D-Dev] [9] RFR JDK-8072682: getBounds call on graphics.getDeviceConfiguration() returning cached information

Hi All, Please review a fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-8072682 webrev: http://cr.openjdk.java.net/~psadhukhan/8072682/webrev.00/ BufferedImageGraphicsConfig creates a cache to store the BufferedImage information but it was found that the cache shares the

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8072682: getBounds call on graphics.getDeviceConfiguration() returning cached information

On 10/9/15 8:37 AM, Sergey Bylokhov wrote: Hi, Prasanta. It seems that width fields are not used after the fix and can be removed. On 08.10.15 11:12, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-8072682 webrev: http

Re: [OpenJDK 2D-Dev] [9] RFR JDK-7161283: [macosx]filedialog didn't pop up for awt test InvalidParametersNativeTest

Gentle reminder for review. Regards Prasanta On 10/9/2015 12:34 PM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-7161283 webrev: http://cr.openjdk.java.net/~psadhukhan/7161283/webrev.00/ The bug mentioned that FileDialog

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-8023213 [macosx] closed/java/awt/FontClass/NaNTransform.java fails on MacOS X 10.9

Gentle reminder for review Regards Prasanta On 10/6/2015 3:25 PM, prasanta sadhukhan wrote: Hello All, Please review a fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-8023213 webrev: http://cr.openjdk.java.net/~psadhukhan/8023213/webrev.00/ drawString takes long time in mac native

[OpenJDK 2D-Dev] [9]: RFR JDK-8023213 [macosx] closed/java/awt/FontClass/NaNTransform.java fails on MacOS X 10.9

Hello All, Please review a fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-8023213 webrev: http://cr.openjdk.java.net/~psadhukhan/8023213/webrev.00/ drawString takes long time in mac native call CGContextShowGlyphsAtPoint() if NaN transform is used which translated to x & y being

Re: [OpenJDK 2D-Dev] RFR: [9] JDK-8132985, , Crash in freetypescaler.c due to double free

Gentle reminder to approve and commit this change. Regards Prasanta On 9/28/2015 10:49 AM, prasanta sadhukhan wrote: Hi Phil,Sergey, Could you please approve this fix? I have followed your comment regarding the test. Regards Prasanta On 9/25/2015 10:55 AM, prasanta sadhukhan wrote: Hi All

Re: [OpenJDK 2D-Dev] RFR: [9] JDK-8132985, , Crash in freetypescaler.c due to double free

jtreg. Alternatively (and for me the preferred solution) you could check in a small Type 1 font along with the test such that it will be possible to always execute it stand-alone. Thank you and best regards, Volker On Wed, Sep 30, 2015 at 7:27 AM, prasanta sadhukhan <prasanta.sadhuk...@oracle.com> wr

Re: [OpenJDK 2D-Dev] RFR: [9] JDK-8076540[macosx] NPE due to incorrect threading

Hi Alexander, Can this please be approved and committed please since this is already approved in crucible? Regards Prasanta On 9/25/2015 12:21 PM, prasanta sadhukhan wrote: Hi All, Please review addition of this fixed test in open (moved from closed) Bug: https://bugs.openjdk.java.net

[OpenJDK 2D-Dev] RFR: [9] JDK-8040689 Fonts antialiasing artifacts appear when using translucent composited images

Hi All, Please review a fix for a problem where Antialiased font drawn on a translucent bufferedimage creates artifacts. Bug: https://bugs.openjdk.java.net/browse/JDK-8040689 webrev: http://cr.openjdk.java.net/~psadhukhan/8040689/webrev.00/ Antialiased font rendering was done via software

Re: [OpenJDK 2D-Dev] RFR: [9] JDK-8132985, , Crash in freetypescaler.c due to double free

Hi All, Can this please be reviewed and approved please? Regards Prasanta On 9/21/2015 2:57 PM, prasanta sadhukhan wrote: Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8132985 Webrev: http://cr.openjdk.java.net/~psadhukhan/8132985/webrev.00/ Please review a bug fix whereby freeing

[OpenJDK 2D-Dev] RFR: [9] JDK-8076540[macosx] NPE due to incorrect threading

Hi All, Please review addition of this fixed test in open (moved from closed) Bug: https://bugs.openjdk.java.net/browse/JDK-8076540 webrev: http://cr.openjdk.java.net/~psadhukhan/8076540/webrev/ The review request for fix in this closed test was raised internally and approved. Regards

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8140530, , Creating a VolatileImage with size 0, 0 results in no longer working g2d.drawStri

en the IAE will be thrown from createCompatibleWritableRaster() If you think it's ok, we can catch 0 width,height in SunVolatileImage constructor before it calls VolatileSurfacemaanger. initialize() so that it gets trapped at higher level? Please advise. Regards Prasanta ...jim On 11/30/

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8140530, , Creating a VolatileImage with size 0, 0 results in no longer working g2d.drawStri

consistency... ...jim On 12/2/15 11:18 PM, prasanta sadhukhan wrote: Hi Jim, On 12/3/2015 12:38 AM, Jim Graham wrote: Hi Prasanta, (On a practical note, in the HTML version of your message, the text said "webrev.01", but the link in the href pointed to "webr

Re: [OpenJDK 2D-Dev] Review request for JDK-8143562: JPEG reader returns null for getRawImageType()

The fix looks good to me. The spec says "Returns an |ImageTypeSpecifier| indicating the |SampleModel| and |ColorModel| which most closely represents the "raw" internal format of the image. For example, for a JPEG image the raw type might have a YCbCr color space even though the image would

[OpenJDK 2D-Dev] [9] RFR: Test closed/javax/print/attribute/Services_getDocFl.java fails with NullpointerException

Hi All, Please review a fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-8040139 webrev: http://cr.openjdk.java.net/~jdv/prasanta/8040139/webrev.00/ It seems if a IPP printer is not accessible, PrintServiceLookup.lookupPrintServices will return the printer service but

Re: [OpenJDK 2D-Dev] [9] RFR: Test closed/javax/print/attribute/Services_getDocFl.java fails with NullpointerException (8040139)

sive to use "lpstat -p" when simply enumerating available printers. And I think the closed test can be opened. I don't see any problem with it and it was developed internally. -phil. On 12/2/15, 2:35 AM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 Bug: https://bu

[OpenJDK 2D-Dev] [9] RFR JDK-7160052: GlyphVector.setGlyphPosition can throw an exception on valid input

Hi All, Please review a fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-7160052 webrev: http://cr.openjdk.java.net/~psadhukhan/7160052/webrev.00/ Issue: GlyphVector.setGlyphPosition(int glyphIndex, Point2D newPos) can have glyphIndex "equal"

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

11:57 PM *To:* Jayathirth D V *Cc:* Prasanta Sadhukhan; 2d-dev@openjdk.java.net *Subject:* Re: Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header Approved. -phil. On 11/24/2015 01:39 AM, Jayathirth D V wrote: Hi Phil, I have re

[OpenJDK 2D-Dev] [9] RFR: JDK-8140530, , Creating a VolatileImage with size 0, 0 results in no longer working g2d.drawStri

Hi All, Please review a fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-8140530 webrev: http://cr.openjdk.java.net/~psadhukhan/8140530/webrev.00/ The issue was creating a volatileImage with 0 width, height does not result in IllegalArgumentException. But, when we try to create a

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

*From:*prasanta sadhukhan *Sent:* Monday, November 23, 2015 5:15 PM *To:* Jayathirth D V *Cc:* Philip Race; 2d-dev@openjdk.java.net *Subject:* Re: Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header On 11/23/2015 5:11 PM, Jayathirth D V wrote:

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

etting the width & height repeatedly . You can get it once and use that info in the loop. It's not going to change in runtime, isn;t it :-) Regards Prasanta Thanks, Jay *From:*prasanta sadhukhan *Sent:* Monday, November 23, 2015 4:43 PM *To:* Jayathirth D V; 2d-dev@openjdk.java.net *C

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Looks ok to me. But probably you could check for image width programmatically instead of hardcoding to 64 in testcode. Regards Prasanta On 11/23/2015 4:09 PM, Jayathirth D V wrote: Hello All, _Please review following fix in JDK9:_ __ Bug : https://bugs.openjdk.java.net/browse/JDK-8041501

[OpenJDK 2D-Dev] [9]RFR: JDK-7063986, , Wrong JNi method call in font scaler

Hi All, Please review a simple fix for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-7063986 webrev: http://cr.openjdk.java.net/~psadhukhan/7063986/webrev/ It is found that the JNI invocation sun.font.Type1Font.readFile() from freeTypefontScaler.c is wrong. readFile() type is void but JNI

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-8023213 [macosx] closed/java/awt/FontClass/NaNTransform.java fails on MacOS X 10.9

in CStrike.java. On 17.11.15 9:12, prasanta sadhukhan wrote: Hi Phil, I have updated webrev to explicitly set glyph image width/height to be 0 in case of NaN transform. Could you please review it? http://cr.openjdk.java.net/~psadhukhan/8023213/webrev.02/ Regards Prasanta On 11/17/2015 3:23 AM, Phil Race

Re: [OpenJDK 2D-Dev] Review request for JDK-8144744 : ImageWriter.replacePixels() specification is incorrect regarding null ImageWriteParam

Looks ok to me and as approved in ccc http://ccc.us.oracle.com/8144744 Regards Prasanta On 1/13/2016 3:38 PM, Jayathirth D V wrote: Hi, _Please review a simple fix in JDK9:_ Bug : https://bugs.openjdk.java.net/browse/JDK-8144744 Webrev : http://cr.openjdk.java.net/~jdv/8144744/webrev.00/

[OpenJDK 2D-Dev] [9] RFR: JDK-6966350:Empty pages when printing on Lexmark E352dn PS3 with "1200 IQ" setting

Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-6966350 The issue was if we select 1200IQ Normal (default) setting in Lexmark E352dn PS3 or Dell 5310n printer, it does not print the output and we get empty pages. It was because DEVMODE windows structure returns 600 for

[OpenJDK 2D-Dev] [9] RFR JDK-8158758: [TEST_BUG] test/java/awt/print/PrinterJob/LandscapeStackOverflow.java fails on timeout

Hi All, Please review a testbug fix for jdk9 where it was seen that jtreg times out if print dialog ok/cancel button is not pressed. Bug: https://bugs.openjdk.java.net/browse/JDK-8158758 webrev: http://cr.openjdk.java.net/~psadhukhan/8158758/webrev.00/ Fix is not to show print dialog as

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8158520: [TEST_BUG] java/awt/PrintJob/PrinterException.java fails on timeout

Hi Sergey, Please find the modified webrev with ESC. The previous bug can also be reproduced with this without the 7161283 fix. http://cr.openjdk.java.net/~psadhukhan/8158520/webrev.01/ Regards Prasanta On 6/3/2016 7:46 PM, prasanta sadhukhan wrote: Ok. we can pass VK_ESCAPE instead

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6601097:Margins are not reset to hardware margins when width/height is 0 or -ve alongwith x, y

ided by DPI to get inches. Also I am not sure that the *entire* width/height of the paper is what you want here but that is secondary to the first issue -phil On 5/19/16, 2:59 AM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 which is a continuation of the fix of

Re: [OpenJDK 2D-Dev] Review Request: JDK-6457721: Stroke width incorrect while printing

Fix looks good to me. But, do we not need to do the same for 209 minLineWidth = Math.max(Math.abs(minPenSize.x) 210 Math.abs(minPenSize.y)); For the test the instruction textarea is editable which needs to be made read-only.

[OpenJDK 2D-Dev] [9]: RFR JDK-8159134: [PIT][TEST_BUG] failed to run java/awt/print/PrinterJob/PrintDlgSelectionAttribTest.java

Hi All, Increased the timeout of this manual test so that user can read and verify the instructions within timelimit to avoid timeout. Bug:https://bugs.openjdk.java.net/browse/JDK-8159134 webrev: http://cr.openjdk.java.net/~psadhukhan/8159134/webrev.00/ Regards Prasanta

[OpenJDK 2D-Dev] [9] RFR JDK-8158520: [TEST_BUG] java/awt/PrintJob/PrinterException.java fails on timeout

Hi All, Please review a test bug which was added for bug 7161283. Toolkit.getPrintJob() threw a NPE if no printer was available. Although the testcase was working ok in failure case by throwing NPE, in pass case it was waiting for manual intervention causing jtreg to fail on timeout. Made

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8158520: [TEST_BUG] java/awt/PrintJob/PrinterException.java fails on timeout

Ok. we can pass VK_ESCAPE instead of VK_ENTER and it works ok. Regards Prasanta On 6/3/2016 7:37 PM, prasanta sadhukhan wrote: No, we do not really need to print anything but we need to show the printdialog to reproduce the previous bug. But to avoid human interaction ,we need to close

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6966350:Empty pages when printing on Lexmark E352dn PS3 with "1200 IQ" setting

but this will help in getting printing to be working in those printers. If we find anything in near future, we will update this code . Regards Prasanta -phil. On 06/09/2016 04:35 AM, prasanta sadhukhan wrote: Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-6966350 The issue was if we select 1

[OpenJDK 2D-Dev] [9] RFR JDK-6218397:Printing to file does not throw a PrinterException if the file cannot be created

Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-6218397 The issue was if the linux disk is full and we are trying to "print to file" then PrinterException is not thrown and a 0 byte file is created. Although I am not able to reproduce this behaviour, because when I make my disk full

Re: [OpenJDK 2D-Dev] Review Request for JDK-6386906 : Faulty rounding code in BMPImageReader.decodeRLE4()

+1 Regards Prasanta On 6/15/2016 12:23 PM, Jayathirth D V wrote: Hi Jim, Thanks for the review. I have updated the webrev for reference: http://cr.openjdk.java.net/~jdv/6386906/webrev.02/ Thanks, Jay -Original Message- From: Jim Graham Sent: Wednesday, June 15, 2016 4:15 AM To:

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8158520: [TEST_BUG] java/awt/PrintJob/PrinterException.java fails on timeout

something or cancel(ESC) will be enough to reproduce the previous bug? On 03.06.16 14:46, prasanta sadhukhan wrote: Please review a test bug which was added for bug 7161283. Toolkit.getPrintJob() threw a NPE if no printer was available. Although the testcase was working ok in failure case by t

[OpenJDK 2D-Dev] [9] RFR 6212751: DOC: ServiceUI.printDialog() need to enhance the description for X, Y coordinates

Hi All, Please review a doc fix for jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-6212751 webrev: http://cr.openjdk.java.net/~psadhukhan/6212751/webrev.00/ After JDK-8138749 multimonitor support fix, the doc needs some change. It was

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6842011: StackOverflowError printing landscape with scale and transform

(I'm guessing/hoping we can add small "fixup" APIs like that after FC since it doesn't really represent a "feature"...?) ...jim On 5/22/16 11:53 PM, prasanta sadhukhan wrote: Hi Jim, On 5/21/2016 3:20 AM, Jim Graham wrote: We should acknowledge that the

Re: [OpenJDK 2D-Dev] RFR: 8054991 : sun.font.GlyphList uses broken double-checked locking

Hi Phil, On 5/26/2016 3:48 AM, Phil Race wrote: bug : https://bugs.openjdk.java.net/browse/JDK-8054991 There is a comment in there about a proposed patch but I can't find it. I guess the proposed patch suggested was this: diff -r 84ff8117acd2 src/share/classes/sun/font/GlyphList.java ---

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6601097:Margins are not reset to hardware margins when width/height is 0 or -ve alongwith x, y

not sure that the *entire* width/height of the paper is what you want here but that is secondary to the first issue -phil On 5/19/16, 2:59 AM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 which is a continuation of the fix of JDK-6543815. Bug: https://bugs.openjdk.java.net

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6842011: StackOverflowError printing landscape with scale and transform

On 5/26/2016 4:19 PM, prasanta sadhukhan wrote: Hi Phil, On 5/25/2016 10:10 PM, Philip Race wrote: I am OK with committing the clarifying javadoc as part of this fix and filing a new RFE for the new method - to be fixed at some later date. new RFE created https://bugs.openjdk.java.net

[OpenJDK 2D-Dev] [9] RFR JDK-4957035:Code given in api is not compilable: docs/api/javax/print/package-summary.html

Hi All, Please review a fix in jdk9 doc whereby the sample code given in the doc is not compilable Bug: https://bugs.openjdk.java.net/browse/JDK-4957035 webrev: http://cr.openjdk.java.net/~psadhukhan/4957035/webrev.00/ MediaSize class has no public attribute A4 so using MediaSize.A4 is not

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6842011: StackOverflowError printing landscape with scale and transform

HI Phil, Jim, I have modified webrev to address Jim's doc change. Please review http://cr.openjdk.java.net/~psadhukhan/6842011/webrev.02/ I will send the ccc link separately to you for approval. On 5/31/2016 11:12 PM, Phil Race wrote: On 05/26/2016 03:49 AM, prasanta sadhukhan wrote: Hi

Re: [OpenJDK 2D-Dev] [9] RFR 6212751: DOC: ServiceUI.printDialog() need to enhance the description for X, Y coordinates

t under 5109347). -phil. On 05/27/2016 04:54 AM, prasanta sadhukhan wrote: Hi All, Please review a doc fix for jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-6212751 webrev: http://cr.openjdk.java.net/~psadhukhan/6212751/webrev.00/ After JDK-8138749 <https://bugs.openjdk.java.net

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4957035:Code given in api is not compilable: docs/api/javax/print/package-summary.html

7.05.16 10:14, prasanta sadhukhan wrote: Hi All, Please review a fix in jdk9 doc whereby the sample code given in the doc is not compilable Bug: https://bugs.openjdk.java.net/browse/JDK-4957035 webrev: http://cr.openjdk.java.net/~psadhukhan/4957035/webrev.00/ MediaSize class has no public attri

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6218397:Printing to file does not throw a PrinterException if the file cannot be created

the delete will fail. Attempt to close the open stream first (in a try .. catch I suppose). -phil. On 6/15/16, 3:25 AM, prasanta sadhukhan wrote: Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-6218397 The issue was if the linux disk is full and we are trying to "print to

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6966350:Empty pages when printing on Lexmark E352dn PS3 with "1200 IQ" setting

PM *To:* Prasanta Sadhukhan *Cc:* 2d-dev@openjdk.java.net *Subject:* Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6966350:Empty pages when printing on Lexmark E352dn PS3 with "1200 IQ" setting Hi Prasanta, I tried to run the test but it looks like you are not creating object for proper class

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6218397:Printing to file does not throw a PrinterException if the file cannot be created

Hi Phil,All, Added file delete in another case where we throw PrinterException. http://cr.openjdk.java.net/~psadhukhan/6218397/webrev.02/ Regards Prasanta On 6/16/2016 1:40 PM, prasanta sadhukhan wrote: Modified webrev to close output stream. http://cr.openjdk.java.net/~psadhukhan/6218397

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6218397:Printing to file does not throw a PrinterException if the file cannot be created

will be written to the file. http://cr.openjdk.java.net/~psadhukhan/6218397/webrev.03/ Regards Prasanta On 6/20/2016 12:01 PM, prasanta sadhukhan wrote: Hi Phil,All, Added file delete in another case where we throw PrinterException. http://cr.openjdk.java.net/~psadhukhan/6218397/webrev.02/ Regards

Re: [OpenJDK 2D-Dev] RFR: 4497648: TextLayout equals method is not implemented

Looks ok to me. Regards Prasanta On 6/19/2016 4:46 AM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-4497648 Webrev : http://cr.openjdk.java.net/~prr/4497648/ TextLayout is a final class that derives directly from Object. It defines boolean equals(TextLayout) and over-rides

Re: [OpenJDK 2D-Dev] [9] Review Request- JDK-8152971- JNI Warning with -Xcheck:jni

dly take a look at the changes at your convenience & provide the suggestions. Thank you for your review Have a good day Prahalad N. From: Prasanta Sadhukhan Sent: Monday, June 27, 2016 11:51 AM To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net Cc: Philip Race; Jayathirth D V; Praveen Srivas

[OpenJDK 2D-Dev] [9] RFR JDK-5049012: PrintToFile option is not disabled for flavors that do not support destination

Hi All, Please review a fix for an issue where it is seen that "Print-To-File" option is enabled even for flavors that do not support Destination attribute even though isAttributeValueSupported for that flavor returns false. Bug: https://bugs.openjdk.java.net/browse/JDK-5049012 webrev:

Re: [OpenJDK 2D-Dev] [9] Review Request- JDK-8152971- JNI Warning with -Xcheck:jni

addition,no new Jtreg failureswere found withthe proposed changes. Kindly review the changes at your convenience & provide your feedback. Thank you for your time in review Have a good day Prahalad N. -Original Message- From: Prahalad Kumar Narayanan Sent: Wednesday, June 22, 2016

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6601097:Margins are not reset to hardware margins when width/height is 0 or -ve alongwith x, y

w <= 0) iw = (float)(page.getPaper().getWidth()/DPI) - (ix*2); if we have ix = 500 and iw = -20 for a paper with width 800 this will result in iw = 800 - (500*2) = -200 .. -phil. On 6/8/16, 4:42 AM, prasanta sadhukhan wrote: Hi Phil, As discussed offline, regarding mpa modification in both

Re: [OpenJDK 2D-Dev] (Review request) JDK-8152971: -Xcheck:jni warning

Please mention for which jdk release you are asking this review for like [9] for jdk9 !! awt_Component.cpp: Should we continue if there is any exception? You are just clearing the exception here, should we also not return as the "obj" values are going to be used later on which again will

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8138749, , Revisited: PrinterJob.printDialog() does not support multi-mon, always displayed on primary

On 2/4/2016 11:01 AM, prasanta sadhukhan wrote: Hi Phil, On 2/3/2016 11:49 PM, Phil Race wrote: Hi, I think it is worth addressing all this at once and I think it can be done entirely in RPJ, leaving ServiceUI alone. Ie fix it just for the case where RPJ displays the dialog(s). RPJ

  1   2   3   4   5   6   >