On Tue, 15 Sep 2020 19:40:28 GMT, Phil Race wrote:
>> This issue relates to JDK-8250639 '☂ Address reliance on default
>> constructors in the java.desktop module'. The
>> following classes have had an explicit no-arg constructor added, with a
>> protected access modifier and accompanying API
>>
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
Hi,
CR 7110002 proposes to rename the unix version of the awt toolkit
libraries to allow them reside in the same directory as libawt.
xawt/libmawt.so -> libawt_xawt.so
headless/libmawt.so -> libawt_headless.so
The proposed new library names are prefixed with 'libawt' since they are
su
t;, MAXPATHLEN-len-1);
/* Check if it exists */
if (stat(buf, &statbuf) == -1 && errno == ENOENT) {
/* No - this is a reduced-headless-jre so use special HToolkit */
Sorry I didn't think of this earlier.
Thanks,
David
On 9/11/2011 10:28 PM, Chris Hegarty wrote:
Hi,
CR 7110002 p
This is a follow up to an issue that came up during discussion of
another fix. Essentially, JDK classes should use j.u.ServiceLoader
rather than sun.misc.Service.
http://cr.openjdk.java.net/~chegar/7116946/webrev.00/webrev/
And a few warning cleanups, given the date that's in it ;-) Since
g
Ananiev wrote:
Hi, Chris,
the fix looks fine.
Thanks,
Artem
On 11/9/2011 4:28 PM, Chris Hegarty wrote:
Hi,
CR 7110002 proposes to rename the unix version of the awt toolkit
libraries to allow them reside in the same directory as libawt.
xawt/libmawt.so -> libawt_xawt.so
headless/libmawt
Michael,
Looks good to me.
Trivially, the generic type in ComponentBeanInfo could simply be
Class, since the actual type is not used. But, what you have is fine.
Thanks for this contribution. I'm sure Stuart will do the integration
for you.
-Chris.
On 02/ 4/12 07:48 AM, Michael Barker wr
On 04/02/2012 11:12, Alan Bateman wrote:
I skimmed through this and just wonder about the changes to
java.beans.beancontext.BeansSupportContext. It's a public type so adding
a type parameter to the protected bcmListeners may be an issue.
Oh, good catch Alan, I missed this. This part of th
I think you should just drop the changes to this file.
-Chris.
Michael Barker wrote:
>> Oh, good catch Alan, I missed this. This part of the change should be
>> reversed ( at least in the context of warnings cleanup ).
>
>Should I switch it to a wild card (protected transient ArrayList
>bcmList
iew_bug.do?bug_id=7143230
[2]
http://mail.openjdk.java.net/pipermail/jdk8-dev/2012-February/000715.html
[3] http://openjdk.java.net/guide/producingChangeset.html
On 2/4/12 12:12 AM, Chris Hegarty wrote:
Thanks for this, looks great.
Good to see JarVerifier getting some much needed TLC.
-Chris.
O
[ cc'ing awt-dev & 2d-dev ]
The change looks fine Magnus, though it may be best to push through the
awt or 2d forest. Members of these groups, cc'ed, are in a better
position to comment on this.
Oh, just to clarify, I agree and approve this change (as much as my
approval counts ;-) ). Just n
On 27/04/2012 21:37, Jim Graham wrote:
Thanks, sorry, I missed the part where this was responding to a change
that is already under way in the new build system...
Right, but it would be nice to trivially cleanup (remove these files)
from FILES_export list in the old build system.
-Chris.
On 06/19/2013 10:38 PM, Kurchi Hazra wrote:
Hi,
The class src/solaris/classes/sun/print/AttributeClass.java overrides
Object.equals() but not Object.hashCode() because of which
we get a warning everytime we build jdk8/tl. Here is a suggestion to
remove the warning:
http://cr.openjdk.java.net
age of getting it into 2d, rather than tl (
more testing before integration, PIT, etc ).
Alternatively, someone from the "2d" area could sponsor Kurchi's
changeset into 2d.
-Chris.
-phil.
Thanks,
- Kurchi
On 6/20/2013 1:37 AM, Chris Hegarty wrote:
On 06/19/2013 10:38 PM,
On 21/06/2013 09:48, Alan Bateman wrote:
On 21/06/2013 09:45, Chris Hegarty wrote:
:
Alternatively, someone from the "2d" area could sponsor Kurchi's
changeset into 2d.
Kurchi is a jdk8 committer so she should be able to push to any of the
jdk8 integration forests, including
Volker,
I skimmed over the networking part of the changes, and nothing jumps out
at me. I'd like to spend a little more time doing a more detailed
review, but I will not have time to do this until after JavaOne.
-Chris.
On 09/16/2013 08:30 PM, Volker Simonis wrote:
Resending this to more li
On 26 Nov 2013, at 18:08, Iris Clark wrote:
>> So overall it looks good to me and should be pushed to the staging > forest
>> once you hear from others that commented previously.
>
> I think that means Chris Hegarty, Michael McMahon, and Sergey Bylokhov.
> Alan,
Forwarding to additional area specific mailing lists, as there are changes
in the webrev that affect their area.
-Chris.
Begin forwarded message:
> From: Chris Hegarty
> Subject: RFR [9] 8140606: Update library code to use internal Unsafe
> Date: 28 October 2015 19:55:41 GMT
> To
On 1 Apr 2016, at 23:19, Phil Race wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8147544
> Fix: http://cr.openjdk.java.net/~prr/8147544/
Your changes look ok to me. Thanks for doing this Phil.
-Chris.
> ManagedLocalThreads is now superseded by a standard
> constructor on java.lang.T
19 matches
Mail list logo
